[kudu-CR] [tools] kudu CLI auto detects replication scheme

["Mike Percy (Code Review)" <ge...@cloudera.org>]

Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8915 )

Change subject: [tools] kudu CLI auto detects replication scheme
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8915/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8915/3//COMMIT_MSG@7
PS3, Line 7: [tools] kudu CLI auto detects replication scheme
nit: how about:

  [tools] make the replica move tool auto-detect the replication scheme

per https://gist.github.com/robertpainsi/b632364184e70900af4ab688decf6f53 (we don't really follow all these rules but the imperative mood makes for a more readable message; i.e. "add", "make", "remove", "fix", etc)


http://gerrit.cloudera.org:8080/#/c/8915/3/src/kudu/consensus/consensus.proto
File src/kudu/consensus/consensus.proto:

http://gerrit.cloudera.org:8080/#/c/8915/3/src/kudu/consensus/consensus.proto@496
PS3, Line 496:   optional ReplicaManagementInfoPB replica_management_info = 3;
nit: we usually leave the error as the last entry in the message, even if that means the field indexes end up out of order



-- 
To view, visit http://gerrit.cloudera.org:8080/8915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia536c1f64ef8173aa4385db8ba01581bc3528154
Gerrit-Change-Number: 8915
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Sat, 06 Jan 2018 02:44:09 +0000
Gerrit-HasComments: Yes