You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Vijay (JIRA)" <ji...@apache.org> on 2010/01/28 19:29:34 UTC

[jira] Created: (CASSANDRA-745) Support Range Queries all the partitioners currently supported.

Support Range Queries all the partitioners currently supported.
---------------------------------------------------------------

                 Key: CASSANDRA-745
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-745
             Project: Cassandra
          Issue Type: New Feature
          Components: Core
    Affects Versions: 0.6
         Environment: Linux, Cassandra trunk
            Reporter: Vijay
            Assignee: Vijay
             Fix For: 0.6


Due to the changes which was made to incorprate Decorated keys in cassandra we can add this support with some minor changes. Basically this patch will support the Range queries on the keyspaces.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-745) Support Range Queries all the partitioners currently supported.

Posted by "Vijay (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vijay updated CASSANDRA-745:
----------------------------

    Attachment:     (was: 745-Patch.txt)

> Support Range Queries all the partitioners currently supported.
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-745
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-745
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.6
>         Environment: Linux, Cassandra trunk
>            Reporter: Vijay
>            Assignee: Vijay
>             Fix For: 0.6
>
>         Attachments: 745-Patch.txt
>
>
> Due to the changes which was made to incorprate Decorated keys in cassandra we can add this support with some minor changes. Basically this patch will support the Range queries on the keyspaces.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-745) Support Range Queries all the partitioners currently supported.

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806172#action_12806172 ] 

Jonathan Ellis commented on CASSANDRA-745:
------------------------------------------

I agree that doing range queries against RP isn't by itself particularly useful, but it seems to be a popular request and there's no real reason to not support it now that we are using DecoratedKey pervasively.

> Support Range Queries all the partitioners currently supported.
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-745
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-745
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.6
>         Environment: Linux, Cassandra trunk
>            Reporter: Vijay
>            Assignee: Vijay
>             Fix For: 0.6
>
>         Attachments: 745-Patch.txt, 745-v2.txt
>
>
> Due to the changes which was made to incorprate Decorated keys in cassandra we can add this support with some minor changes. Basically this patch will support the Range queries on the keyspaces.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-745) Support Range Queries all the partitioners currently supported.

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806070#action_12806070 ] 

Jonathan Ellis commented on CASSANDRA-745:
------------------------------------------

how is the change to DSS related?

> Support Range Queries all the partitioners currently supported.
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-745
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-745
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.6
>         Environment: Linux, Cassandra trunk
>            Reporter: Vijay
>            Assignee: Vijay
>             Fix For: 0.6
>
>         Attachments: 745-Patch.txt
>
>
> Due to the changes which was made to incorprate Decorated keys in cassandra we can add this support with some minor changes. Basically this patch will support the Range queries on the keyspaces.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-745) Support Range Queries all the partitioners currently supported.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834893#action_12834893 ] 

Hudson commented on CASSANDRA-745:
----------------------------------

Integrated in Cassandra #357 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/357/])
    

> Support Range Queries all the partitioners currently supported.
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-745
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-745
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.6
>         Environment: Linux, Cassandra trunk
>            Reporter: Vijay
>            Assignee: Jonathan Ellis
>             Fix For: 0.6
>
>         Attachments: 745-Patch.txt, 745-v2.txt
>
>
> Due to the changes which was made to incorprate Decorated keys in cassandra we can add this support with some minor changes. Basically this patch will support the Range queries on the keyspaces.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CASSANDRA-745) Support Range Queries all the partitioners currently supported.

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis resolved CASSANDRA-745.
--------------------------------------

    Resolution: Fixed
      Assignee: Jonathan Ellis  (was: Vijay)

committed

> Support Range Queries all the partitioners currently supported.
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-745
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-745
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.6
>         Environment: Linux, Cassandra trunk
>            Reporter: Vijay
>            Assignee: Jonathan Ellis
>             Fix For: 0.6
>
>         Attachments: 745-Patch.txt, 745-v2.txt
>
>
> Due to the changes which was made to incorprate Decorated keys in cassandra we can add this support with some minor changes. Basically this patch will support the Range queries on the keyspaces.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-745) Support Range Queries all the partitioners currently supported.

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806160#action_12806160 ] 

Stu Hood commented on CASSANDRA-745:
------------------------------------

A Thrift API call that uses Tokens would probably work, but I think before designing that method, you should document what you think the entire MapReduce/Cassandra interaction will look like. You're going to need more API calls to get locality and partition information.

> Support Range Queries all the partitioners currently supported.
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-745
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-745
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.6
>         Environment: Linux, Cassandra trunk
>            Reporter: Vijay
>            Assignee: Vijay
>             Fix For: 0.6
>
>         Attachments: 745-Patch.txt
>
>
> Due to the changes which was made to incorprate Decorated keys in cassandra we can add this support with some minor changes. Basically this patch will support the Range queries on the keyspaces.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-745) Support Range Queries all the partitioners currently supported.

Posted by "Vijay (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vijay updated CASSANDRA-745:
----------------------------

    Attachment: 745-Patch.txt

Removed DSS changes

> Support Range Queries all the partitioners currently supported.
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-745
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-745
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.6
>         Environment: Linux, Cassandra trunk
>            Reporter: Vijay
>            Assignee: Vijay
>             Fix For: 0.6
>
>         Attachments: 745-Patch.txt
>
>
> Due to the changes which was made to incorprate Decorated keys in cassandra we can add this support with some minor changes. Basically this patch will support the Range queries on the keyspaces.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-745) Support Range Queries all the partitioners currently supported.

Posted by "Vijay (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vijay updated CASSANDRA-745:
----------------------------

    Attachment:     (was: 745-Patch.txt)

> Support Range Queries all the partitioners currently supported.
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-745
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-745
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.6
>         Environment: Linux, Cassandra trunk
>            Reporter: Vijay
>            Assignee: Vijay
>             Fix For: 0.6
>
>         Attachments: 745-Patch.txt
>
>
> Due to the changes which was made to incorprate Decorated keys in cassandra we can add this support with some minor changes. Basically this patch will support the Range queries on the keyspaces.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-745) Support Range Queries all the partitioners currently supported.

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-745:
-------------------------------------

    Attachment: 745-v2.txt

Attached is a patch that makes empty strings always return the MINIMUM token, and DecoratedKeys containing the MINIMUM token always be considered empty.  This is something we probably should be doing anyway for consistency.  (It was already true for OPP, but not COPP or RP.)

No further special casing should be necessary because we have already abstracted out code that needs to work across multiple partitioners to use IPartitioner.isEmpty, including getRangeSlice.

> Support Range Queries all the partitioners currently supported.
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-745
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-745
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.6
>         Environment: Linux, Cassandra trunk
>            Reporter: Vijay
>            Assignee: Vijay
>             Fix For: 0.6
>
>         Attachments: 745-Patch.txt, 745-v2.txt
>
>
> Due to the changes which was made to incorprate Decorated keys in cassandra we can add this support with some minor changes. Basically this patch will support the Range queries on the keyspaces.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-745) Support Range Queries all the partitioners currently supported.

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806453#action_12806453 ] 

Stu Hood commented on CASSANDRA-745:
------------------------------------

+1
I think this patch is a good idea as long as we document that reading the entire keyspace this way is not clever.

> Support Range Queries all the partitioners currently supported.
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-745
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-745
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.6
>         Environment: Linux, Cassandra trunk
>            Reporter: Vijay
>            Assignee: Vijay
>             Fix For: 0.6
>
>         Attachments: 745-Patch.txt, 745-v2.txt
>
>
> Due to the changes which was made to incorprate Decorated keys in cassandra we can add this support with some minor changes. Basically this patch will support the Range queries on the keyspaces.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-745) Support Range Queries all the partitioners currently supported.

Posted by "Vijay (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vijay updated CASSANDRA-745:
----------------------------

    Attachment: 745-Patch.txt

> Support Range Queries all the partitioners currently supported.
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-745
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-745
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.6
>         Environment: Linux, Cassandra trunk
>            Reporter: Vijay
>            Assignee: Vijay
>             Fix For: 0.6
>
>         Attachments: 745-Patch.txt
>
>
> Due to the changes which was made to incorprate Decorated keys in cassandra we can add this support with some minor changes. Basically this patch will support the Range queries on the keyspaces.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-745) Support Range Queries all the partitioners currently supported.

Posted by "Vijay (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vijay updated CASSANDRA-745:
----------------------------

    Attachment: 745-Patch.txt

Plz see the attachement, it has the fix to do the Range Query. Also have a small change update on DatacenterShared statergy which is due for a long time :)

Regards
Vijay

> Support Range Queries all the partitioners currently supported.
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-745
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-745
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.6
>         Environment: Linux, Cassandra trunk
>            Reporter: Vijay
>            Assignee: Vijay
>             Fix For: 0.6
>
>         Attachments: 745-Patch.txt
>
>
> Due to the changes which was made to incorprate Decorated keys in cassandra we can add this support with some minor changes. Basically this patch will support the Range queries on the keyspaces.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-745) Support Range Queries all the partitioners currently supported.

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806145#action_12806145 ] 

Stu Hood commented on CASSANDRA-745:
------------------------------------

This patch sets finishKey to the minimum token if the start_key is equal to the empty string, which probably indicates that it needs a lot more testing.

Also, I don't think this will be very useful without some API changes. Yes, someone using RandomPartitioner will be able to pass start="" and finish="" to get all of the rows in their cluster, but that would be an extremely inefficient way to get all rows. Additionally, if they use anything other than the empty string, the behaviour becomes undefined: MD5s won't sort the same way that strings do, so passing in strings is a guessing game.

If this is supposed to be for Hadoop integration, I suggest that we try to build an efficient API call specifically for that task, including locality information, and dividing the keyspace into a certain number of input partitions.

> Support Range Queries all the partitioners currently supported.
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-745
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-745
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.6
>         Environment: Linux, Cassandra trunk
>            Reporter: Vijay
>            Assignee: Vijay
>             Fix For: 0.6
>
>         Attachments: 745-Patch.txt
>
>
> Due to the changes which was made to incorprate Decorated keys in cassandra we can add this support with some minor changes. Basically this patch will support the Range queries on the keyspaces.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-745) Support Range Queries all the partitioners currently supported.

Posted by "Vijay (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806147#action_12806147 ] 

Vijay commented on CASSANDRA-745:
---------------------------------

The only way in that case, is to send the Md5sum instead of sending strings... if done it will start and end till the md5sum specified. 
So we can add the API saying wether to start md5 and finish md5's?

> Support Range Queries all the partitioners currently supported.
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-745
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-745
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 0.6
>         Environment: Linux, Cassandra trunk
>            Reporter: Vijay
>            Assignee: Vijay
>             Fix For: 0.6
>
>         Attachments: 745-Patch.txt
>
>
> Due to the changes which was made to incorprate Decorated keys in cassandra we can add this support with some minor changes. Basically this patch will support the Range queries on the keyspaces.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.