You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/23 08:13:45 UTC

[GitHub] [flink-table-store] zjureel opened a new pull request, #399: [FLINK-30161] Add table schema validation for full compaction

zjureel opened a new pull request, #399:
URL: https://github.com/apache/flink-table-store/pull/399

   The full compaction producer is not supported in `ValueCountMergeFunction`, it should be checked in `SchemaManager`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-table-store] zjureel commented on pull request #399: [FLINK-30161] Add table schema validation for full compaction

Posted by GitBox <gi...@apache.org>.
zjureel commented on PR #399:
URL: https://github.com/apache/flink-table-store/pull/399#issuecomment-1325091204

   Thanks @JingsongLi  Done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-table-store] zjureel commented on pull request #399: [FLINK-30161] Add table schema validation for full compaction

Posted by GitBox <gi...@apache.org>.
zjureel commented on PR #399:
URL: https://github.com/apache/flink-table-store/pull/399#issuecomment-1324709079

   > Thanks @zjureel !
   > 
   > I find that all kinds of verifications are a bit messy. Can we propose a verification method (Maybe a static method in `CoreOptions`)? It can be called in two places:
   > 
   > 1. `SchemaManager.commit`: When submitting new schema changes.
   > 2. `FileStoreTableFactory.create`: When creating a new table, the verification here is because there may be dynamic options, which also need to be verified.
   
   Sounds good to me, I found there are validations in `CoreOptions` too, we should merge them


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #399: [FLINK-30161] Add table schema validation for full compaction

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on code in PR #399:
URL: https://github.com/apache/flink-table-store/pull/399#discussion_r1030219825


##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/table/FileStoreTableFactory.java:
##########
@@ -63,7 +62,7 @@ public static FileStoreTable create(
         newOptions.set(PATH, tablePath.toString());
 
         // validate merged options
-        validateOptions(new CoreOptions(newOptions));
+        CoreOptions.validateTableOptions(tableSchema, new CoreOptions(newOptions));

Review Comment:
   We could validate new tableSchema. (It's down there)



##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/CoreOptions.java:
##########
@@ -695,6 +691,44 @@ public InlineElement getDescription() {
         }
     }
 
+    /**
+     * Validate the {@link TableSchema} and {@link CoreOptions}.
+     *
+     * <p>TODO validate all items in schema and all keys in options.
+     *
+     * @param schema the schema to be validated
+     * @param options the options to be validated
+     */
+    public static void validateTableOptions(TableSchema schema, CoreOptions options) {

Review Comment:
   Minor: this options can generated by `schema`. Just `validateTableOptions(TableSchema schema)` is OK.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-table-store] JingsongLi merged pull request #399: [FLINK-30161] Add table schema validation for full compaction

Posted by GitBox <gi...@apache.org>.
JingsongLi merged PR #399:
URL: https://github.com/apache/flink-table-store/pull/399


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org