You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "jpountz (via GitHub)" <gi...@apache.org> on 2023/06/21 09:27:46 UTC
[GitHub] [lucene] jpountz commented on issue #12275: Clarify IndexSearcher#setTimeout semantics
jpountz commented on issue #12275:
URL: https://github.com/apache/lucene/issues/12275#issuecomment-1600503443
+1 to improve javadocs
This discussion also relates to https://github.com/apache/lucene/issues/11700.
> I am wondering if we should make the queryTimeout member final and remove the setTimeout method.
I would like it better too. In general, all the setters that `IndexSearcher` has are expected to be called right after calling the constructor, and to never be touched again, so they would be better implemented as final members. I worry this will end up make us implement a builder for IndexSearcher, but it's probably better than what we have today?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org