You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/12 06:17:57 UTC
[GitHub] [doris] liaoxin01 opened a new pull request, #15005: [fix](load) fix that failure of rpc to send batch and concurrent flush memtable may cause data loss
liaoxin01 opened a new pull request, #15005:
URL: https://github.com/apache/doris/pull/15005
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15005: [fix](load) fix that flush memtable concurrently may cause data inconsistency
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15005:
URL: https://github.com/apache/doris/pull/15005#issuecomment-1346023335
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15005: [fix](load) fix that failure of rpc to send batch and concurrent flush memtable may cause data loss
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15005:
URL: https://github.com/apache/doris/pull/15005#issuecomment-1345990538
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zhannngchen commented on a diff in pull request #15005: [fix](load) fix that failure of rpc to send batch and concurrent flush memtable may cause data loss
Posted by GitBox <gi...@apache.org>.
zhannngchen commented on code in PR #15005:
URL: https://github.com/apache/doris/pull/15005#discussion_r1045452632
##########
be/src/runtime/tablets_channel.cpp:
##########
@@ -439,6 +439,10 @@ Status TabletsChannel::add_batch(const TabletWriterAddRequest& request,
LOG(INFO) << "packet has already recept before, expect_seq=" << cur_seq
<< ", recept_seq=" << request.packet_seq();
return Status::OK();
+ } else if (request.packet_seq() > cur_seq) {
Review Comment:
`_get_current_seq` have similar warning, it's duplicate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15005: [fix](load) fix that failure of rpc to send batch and concurrent flush memtable may cause data loss
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15005:
URL: https://github.com/apache/doris/pull/15005#issuecomment-1345956205
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15005: [fix](load) fix that flush memtable concurrently may cause data inconsistency
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15005:
URL: https://github.com/apache/doris/pull/15005#issuecomment-1346020445
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15005: [fix](load) fix that failure of rpc to send batch and concurrent flush memtable may cause data loss
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15005:
URL: https://github.com/apache/doris/pull/15005#issuecomment-1345973534
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring merged pull request #15005: [fix](load) fix that flush memtable concurrently may cause data inconsistency
Posted by GitBox <gi...@apache.org>.
dataroaring merged PR #15005:
URL: https://github.com/apache/doris/pull/15005
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15005: [fix](load) fix that failure of rpc to send batch and concurrent flush memtable may cause data loss
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15005:
URL: https://github.com/apache/doris/pull/15005#issuecomment-1345964909
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15005: [fix](load) fix that failure of rpc to send batch and concurrent flush memtable may cause data loss
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15005:
URL: https://github.com/apache/doris/pull/15005#issuecomment-1345964868
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15005: [fix](load) fix that failure of rpc to send batch and concurrent flush memtable may cause data loss
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15005:
URL: https://github.com/apache/doris/pull/15005#issuecomment-1346011572
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.67 seconds
load time: 478 seconds
storage size: 17123356944 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221212072802_clickbench_pr_61929.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org