You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by vs...@apache.org on 2007/11/15 14:45:34 UTC

svn commit: r595301 - /maven/plugins/trunk/maven-clean-plugin/src/test/java/org/apache/maven/plugin/clean/CleanMojoTest.java

Author: vsiveton
Date: Thu Nov 15 05:45:34 2007
New Revision: 595301

URL: http://svn.apache.org/viewvc?rev=595301&view=rev
Log:
o uncomment tests which plays with locked files.

Modified:
    maven/plugins/trunk/maven-clean-plugin/src/test/java/org/apache/maven/plugin/clean/CleanMojoTest.java

Modified: maven/plugins/trunk/maven-clean-plugin/src/test/java/org/apache/maven/plugin/clean/CleanMojoTest.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-clean-plugin/src/test/java/org/apache/maven/plugin/clean/CleanMojoTest.java?rev=595301&r1=595300&r2=595301&view=diff
==============================================================================
--- maven/plugins/trunk/maven-clean-plugin/src/test/java/org/apache/maven/plugin/clean/CleanMojoTest.java (original)
+++ maven/plugins/trunk/maven-clean-plugin/src/test/java/org/apache/maven/plugin/clean/CleanMojoTest.java Thu Nov 15 05:45:34 2007
@@ -194,92 +194,93 @@
         assertFalse( checkExists( getBasedir() + "/target/test-classes/unit/missing-directory-test/does-not-exist" ) );
     }
 
-    /**
-     * Test the removal of a locked file
-     *
-     * @throws Exception
-     */
-    public void testCleanLockedFile()
-        throws Exception
-    {
-        String pluginPom = getBasedir() + "/src/test/resources/unit/locked-file-test/plugin-pom.xml";
-
-        CleanMojo mojo = (CleanMojo) lookupMojo( "clean", pluginPom );
-        assertNotNull( mojo );
-
-        File f = new File( getBasedir(), "target/test-classes/unit/locked-file-test/buildDirectory/file.txt" );
-        FileChannel channel = null;
-        FileLock lock = null;
-        try
-        {
-            channel = new RandomAccessFile( f, "rw" ).getChannel();
-            lock = channel.lock();
-
-            mojo.execute();
-
-            fail( "Should fail to delete a file that is locked" );
-        }
-        catch ( MojoExecutionException expected )
-        {
-            assertTrue( true );
-        }
-        finally
-        {
-            if ( lock != null )
-            {
-                lock.release();
-            }
-
-            if ( channel != null )
-            {
-                channel.close();
-            }
-        }
-    }
-
-    /**
-     * Test the removal of a locked file
-     *
-     * @throws Exception
-     */
-    public void testCleanLockedFileWithNoError()
-        throws Exception
-    {
-        String pluginPom = getBasedir() + "/src/test/resources/unit/locked-file-test/plugin-pom.xml";
-
-        CleanMojo mojo = (CleanMojo) lookupMojo( "clean", pluginPom );
-        setVariableValueToObject( mojo, "ignoreErrors", Boolean.TRUE );
-        assertNotNull( mojo );
-
-        File f = new File( getBasedir(), "target/test-classes/unit/locked-file-test/buildDirectory/file.txt" );
-        FileChannel channel = null;
-        FileLock lock = null;
-        try
-        {
-            channel = new RandomAccessFile( f, "rw" ).getChannel();
-            lock = channel.lock();
-
-            mojo.execute();
-
-            assertTrue( true );
-        }
-        catch ( MojoExecutionException expected )
-        {
-            fail( "Should display a warning when deleting a file that is locked" );
-        }
-        finally
-        {
-            if ( lock != null )
-            {
-                lock.release();
-            }
-
-            if ( channel != null )
-            {
-                channel.close();
-            }
-        }
-    }
+// Unix will let you get away with it, not sure how to lock the file from Java.
+//    /**
+//     * Test the removal of a locked file
+//     *
+//     * @throws Exception
+//     */
+//    public void testCleanLockedFile()
+//        throws Exception
+//    {
+//        String pluginPom = getBasedir() + "/src/test/resources/unit/locked-file-test/plugin-pom.xml";
+//
+//        CleanMojo mojo = (CleanMojo) lookupMojo( "clean", pluginPom );
+//        assertNotNull( mojo );
+//
+//        File f = new File( getBasedir(), "target/test-classes/unit/locked-file-test/buildDirectory/file.txt" );
+//        FileChannel channel = null;
+//        FileLock lock = null;
+//        try
+//        {
+//            channel = new RandomAccessFile( f, "rw" ).getChannel();
+//            lock = channel.lock();
+//
+//            mojo.execute();
+//
+//            fail( "Should fail to delete a file that is locked" );
+//        }
+//        catch ( MojoExecutionException expected )
+//        {
+//            assertTrue( true );
+//        }
+//        finally
+//        {
+//            if ( lock != null )
+//            {
+//                lock.release();
+//            }
+//
+//            if ( channel != null )
+//            {
+//                channel.close();
+//            }
+//        }
+//    }
+//
+//    /**
+//     * Test the removal of a locked file
+//     *
+//     * @throws Exception
+//     */
+//    public void testCleanLockedFileWithNoError()
+//        throws Exception
+//    {
+//        String pluginPom = getBasedir() + "/src/test/resources/unit/locked-file-test/plugin-pom.xml";
+//
+//        CleanMojo mojo = (CleanMojo) lookupMojo( "clean", pluginPom );
+//        setVariableValueToObject( mojo, "ignoreErrors", Boolean.TRUE );
+//        assertNotNull( mojo );
+//
+//        File f = new File( getBasedir(), "target/test-classes/unit/locked-file-test/buildDirectory/file.txt" );
+//        FileChannel channel = null;
+//        FileLock lock = null;
+//        try
+//        {
+//            channel = new RandomAccessFile( f, "rw" ).getChannel();
+//            lock = channel.lock();
+//
+//            mojo.execute();
+//
+//            assertTrue( true );
+//        }
+//        catch ( MojoExecutionException expected )
+//        {
+//            fail( "Should display a warning when deleting a file that is locked" );
+//        }
+//        finally
+//        {
+//            if ( lock != null )
+//            {
+//                lock.release();
+//            }
+//
+//            if ( channel != null )
+//            {
+//                channel.close();
+//            }
+//        }
+//    }
 
     /**
      * @param dir a dir or a file