You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Elmahrek <ab...@cloudera.com> on 2015/06/16 11:13:49 UTC
Review Request 35500: hive.metastore.sasl.enabled should be set to
true for Oozie integration
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35500/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-2400
https://issues.apache.org/jira/browse/SQOOP-2400
Repository: sqoop-trunk
Description
-------
commit 8102d2445812718c37e6da1976fb1ecc2322a03a
Author: Abraham Elmahrek <ab...@apache.org>
Date: Sun May 31 09:52:58 2015 -0700
SQOOP-2400: hive.metastore.sasl.enabled should be set to true for Oozie integration
:100644 100644 097d622... 59a458b... M src/java/org/apache/sqoop/hive/HiveImport.java
Diffs
-----
src/java/org/apache/sqoop/hive/HiveImport.java 097d622
Diff: https://reviews.apache.org/r/35500/diff/
Testing
-------
Manually
Thanks,
Abraham Elmahrek
Re: Review Request 35500: hive.metastore.sasl.enabled should be set
to true for Oozie integration
Posted by Abraham Elmahrek <ab...@cloudera.com>.
> On June 16, 2015, 4:29 p.m., Qian Xu wrote:
> > src/java/org/apache/sqoop/hive/HiveImport.java, line 332
> > <https://reviews.apache.org/r/35500/diff/2/?file=985632#file985632line332>
> >
> > Generally +1.
> >
> > One NIT: As the similar code appears twice, do you think if we could have a private method `private String[] getHiveArgs(String... extraArgs)` to create the argument array?
Makes sense. Will work with Lists instead though.
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35500/#review88079
-----------------------------------------------------------
On June 16, 2015, 9:57 a.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35500/
> -----------------------------------------------------------
>
> (Updated June 16, 2015, 9:57 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2400
> https://issues.apache.org/jira/browse/SQOOP-2400
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> commit 8102d2445812718c37e6da1976fb1ecc2322a03a
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Sun May 31 09:52:58 2015 -0700
>
> SQOOP-2400: hive.metastore.sasl.enabled should be set to true for Oozie integration
>
> :100644 100644 097d622... 59a458b... M src/java/org/apache/sqoop/hive/HiveImport.java
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/hive/HiveImport.java 097d622
>
> Diff: https://reviews.apache.org/r/35500/diff/
>
>
> Testing
> -------
>
> Manually
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 35500: hive.metastore.sasl.enabled should be set
to true for Oozie integration
Posted by Qian Xu <qi...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35500/#review88079
-----------------------------------------------------------
src/java/org/apache/sqoop/hive/HiveImport.java (line 332)
<https://reviews.apache.org/r/35500/#comment140485>
Generally +1.
One NIT: As the similar code appears twice, do you think if we could have a private method `private String[] getHiveArgs(String... extraArgs)` to create the argument array?
- Qian Xu
On June 16, 2015, 5:57 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35500/
> -----------------------------------------------------------
>
> (Updated June 16, 2015, 5:57 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2400
> https://issues.apache.org/jira/browse/SQOOP-2400
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> commit 8102d2445812718c37e6da1976fb1ecc2322a03a
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Sun May 31 09:52:58 2015 -0700
>
> SQOOP-2400: hive.metastore.sasl.enabled should be set to true for Oozie integration
>
> :100644 100644 097d622... 59a458b... M src/java/org/apache/sqoop/hive/HiveImport.java
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/hive/HiveImport.java 097d622
>
> Diff: https://reviews.apache.org/r/35500/diff/
>
>
> Testing
> -------
>
> Manually
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 35500: hive.metastore.sasl.enabled should be set
to true for Oozie integration
Posted by Qian Xu <qi...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35500/#review89386
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Xu
On June 25, 2015, 10:37 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35500/
> -----------------------------------------------------------
>
> (Updated June 25, 2015, 10:37 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2400
> https://issues.apache.org/jira/browse/SQOOP-2400
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> commit 8102d2445812718c37e6da1976fb1ecc2322a03a
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Sun May 31 09:52:58 2015 -0700
>
> SQOOP-2400: hive.metastore.sasl.enabled should be set to true for Oozie integration
>
> :100644 100644 097d622... 59a458b... M src/java/org/apache/sqoop/hive/HiveImport.java
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/hive/HiveImport.java 097d622
>
> Diff: https://reviews.apache.org/r/35500/diff/
>
>
> Testing
> -------
>
> Manually
>
>
> Thanks,
>
> Abraham Elmahrek
>
>
Re: Review Request 35500: hive.metastore.sasl.enabled should be set
to true for Oozie integration
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35500/
-----------------------------------------------------------
(Updated June 25, 2015, 2:37 p.m.)
Review request for Sqoop.
Bugs: SQOOP-2400
https://issues.apache.org/jira/browse/SQOOP-2400
Repository: sqoop-trunk
Description
-------
commit 8102d2445812718c37e6da1976fb1ecc2322a03a
Author: Abraham Elmahrek <ab...@apache.org>
Date: Sun May 31 09:52:58 2015 -0700
SQOOP-2400: hive.metastore.sasl.enabled should be set to true for Oozie integration
:100644 100644 097d622... 59a458b... M src/java/org/apache/sqoop/hive/HiveImport.java
Diffs (updated)
-----
src/java/org/apache/sqoop/hive/HiveImport.java 097d622
Diff: https://reviews.apache.org/r/35500/diff/
Testing
-------
Manually
Thanks,
Abraham Elmahrek
Re: Review Request 35500: hive.metastore.sasl.enabled should be set
to true for Oozie integration
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35500/
-----------------------------------------------------------
(Updated June 25, 2015, 3:34 a.m.)
Review request for Sqoop.
Bugs: SQOOP-2400
https://issues.apache.org/jira/browse/SQOOP-2400
Repository: sqoop-trunk
Description
-------
commit 8102d2445812718c37e6da1976fb1ecc2322a03a
Author: Abraham Elmahrek <ab...@apache.org>
Date: Sun May 31 09:52:58 2015 -0700
SQOOP-2400: hive.metastore.sasl.enabled should be set to true for Oozie integration
:100644 100644 097d622... 59a458b... M src/java/org/apache/sqoop/hive/HiveImport.java
Diffs (updated)
-----
src/java/org/apache/sqoop/hive/HiveImport.java 097d622
Diff: https://reviews.apache.org/r/35500/diff/
Testing
-------
Manually
Thanks,
Abraham Elmahrek
Re: Review Request 35500: hive.metastore.sasl.enabled should be set
to true for Oozie integration
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35500/
-----------------------------------------------------------
(Updated June 25, 2015, 2:32 a.m.)
Review request for Sqoop.
Bugs: SQOOP-2400
https://issues.apache.org/jira/browse/SQOOP-2400
Repository: sqoop-trunk
Description
-------
commit 8102d2445812718c37e6da1976fb1ecc2322a03a
Author: Abraham Elmahrek <ab...@apache.org>
Date: Sun May 31 09:52:58 2015 -0700
SQOOP-2400: hive.metastore.sasl.enabled should be set to true for Oozie integration
:100644 100644 097d622... 59a458b... M src/java/org/apache/sqoop/hive/HiveImport.java
Diffs (updated)
-----
src/java/org/apache/sqoop/hive/HiveImport.java 097d622
Diff: https://reviews.apache.org/r/35500/diff/
Testing
-------
Manually
Thanks,
Abraham Elmahrek
Re: Review Request 35500: hive.metastore.sasl.enabled should be set
to true for Oozie integration
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35500/
-----------------------------------------------------------
(Updated June 16, 2015, 9:57 a.m.)
Review request for Sqoop.
Bugs: SQOOP-2400
https://issues.apache.org/jira/browse/SQOOP-2400
Repository: sqoop-trunk
Description
-------
commit 8102d2445812718c37e6da1976fb1ecc2322a03a
Author: Abraham Elmahrek <ab...@apache.org>
Date: Sun May 31 09:52:58 2015 -0700
SQOOP-2400: hive.metastore.sasl.enabled should be set to true for Oozie integration
:100644 100644 097d622... 59a458b... M src/java/org/apache/sqoop/hive/HiveImport.java
Diffs (updated)
-----
src/java/org/apache/sqoop/hive/HiveImport.java 097d622
Diff: https://reviews.apache.org/r/35500/diff/
Testing
-------
Manually
Thanks,
Abraham Elmahrek