You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/08/29 02:57:50 UTC

[GitHub] [bookkeeper] StevenLuMT commented on a diff in pull request #3458: Speed up the rebuildinding of RocksDB index

StevenLuMT commented on code in PR #3458:
URL: https://github.com/apache/bookkeeper/pull/3458#discussion_r956854789


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/LocationsIndexRebuildOp.java:
##########
@@ -31,6 +31,9 @@
 import java.util.Date;
 import java.util.Set;
 import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicInteger;
+import java.util.concurrent.atomic.AtomicReference;
+

Review Comment:
   new checkstyle not pass, please clean line:36 newline
   
   <img width="1382" alt="image" src="https://user-images.githubusercontent.com/42990025/187113881-cb0191bf-3ecd-403b-b23f-e5b94d024e84.png">
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org