[GitHub] [couchdb] nickva commented on a diff in pull request #3979: use undefined for timed out responses

[GitBox <gi...@apache.org>]

nickva commented on code in PR #3979:
URL: https://github.com/apache/couchdb/pull/3979#discussion_r862951389


##########
src/fabric/src/fabric_doc_update.erl:
##########
@@ -39,10 +39,15 @@ go(DbName, AllDocs0, Opts) ->
     Acc0 = {length(Workers), length(AllDocs), list_to_integer(W), GroupedDocs, dict:new()},
     Timeout = fabric_util:request_timeout(),
     try rexi_utils:recv(Workers, #shard.ref, fun handle_message/3, Acc0, infinity, Timeout) of
+        {ok, {_, []}} ->
+            erlang:error({internal_server_error, "No Responses For Document Update"});

Review Comment:
   This could alter the behavior of `_bulk_docs` with `docs=[]`. I think we do allow a successful update with docs = [] and return a 200 response.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org