You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2012/03/08 04:19:30 UTC

[jira] [Commented] (MAHOUT-987) Our build is unstable - this should reduce our style warnings by >200

    [ https://issues.apache.org/jira/browse/MAHOUT-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224968#comment-13224968 ] 

jiraposter@reviews.apache.org commented on MAHOUT-987:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4238/
-----------------------------------------------------------

Review request for mahout.


Summary
-------

Generated with:

find . -name *java | xargs perl -pi -e 's/(if|while|for)(/$1 (/'


This addresses bug MAHOUT-987.
    https://issues.apache.org/jira/browse/MAHOUT-987


Diffs
-----

  trunk/core/src/main/java/org/apache/mahout/cf/taste/impl/recommender/knn/ConjugateGradientOptimizer.java 1298262 
  trunk/core/src/main/java/org/apache/mahout/classifier/ConfusionMatrix.java 1298262 
  trunk/core/src/main/java/org/apache/mahout/clustering/lda/LDADriver.java 1298262 
  trunk/core/src/main/java/org/apache/mahout/clustering/lda/LDASampler.java 1298262 
  trunk/core/src/main/java/org/apache/mahout/clustering/lda/cvb/CVB0DocInferenceMapper.java 1298262 
  trunk/core/src/main/java/org/apache/mahout/clustering/lda/cvb/CVB0Driver.java 1298262 
  trunk/core/src/main/java/org/apache/mahout/clustering/lda/cvb/CachingCVB0Mapper.java 1298262 
  trunk/core/src/main/java/org/apache/mahout/clustering/lda/cvb/CachingCVB0PerplexityMapper.java 1298262 
  trunk/core/src/main/java/org/apache/mahout/clustering/lda/cvb/InMemoryCollapsedVariationalBayes0.java 1298262 
  trunk/core/src/main/java/org/apache/mahout/clustering/lda/cvb/ModelTrainer.java 1298262 
  trunk/core/src/main/java/org/apache/mahout/clustering/lda/cvb/TopicModel.java 1298262 
  trunk/core/src/main/java/org/apache/mahout/clustering/spectral/eigencuts/EigencutsDriver.java 1298262 
  trunk/core/src/main/java/org/apache/mahout/common/distance/MahalanobisDistanceMeasure.java 1298262 
  trunk/core/src/main/java/org/apache/mahout/math/DistributedRowMatrixWriter.java 1298262 
  trunk/core/src/main/java/org/apache/mahout/math/MatrixUtils.java 1298262 
  trunk/core/src/main/java/org/apache/mahout/math/hadoop/decomposer/DistributedLanczosSolver.java 1298262 
  trunk/core/src/main/java/org/apache/mahout/math/hadoop/decomposer/HdfsBackedLanczosState.java 1298262 
  trunk/core/src/main/java/org/apache/mahout/math/stats/Sampler.java 1298262 
  trunk/core/src/test/java/org/apache/mahout/clustering/ClusteringTestUtils.java 1298262 
  trunk/core/src/test/java/org/apache/mahout/clustering/lda/TestMapReduce.java 1298262 
  trunk/core/src/test/java/org/apache/mahout/clustering/lda/cvb/TestCVBModelTrainer.java 1298262 
  trunk/core/src/test/java/org/apache/mahout/common/distance/DefaultDistanceMeasureTest.java 1298262 
  trunk/core/src/test/java/org/apache/mahout/math/MatrixWritableTest.java 1298262 
  trunk/core/src/test/java/org/apache/mahout/math/hadoop/TestDistributedRowMatrix.java 1298262 
  trunk/core/src/test/java/org/apache/mahout/math/hadoop/decomposer/TestDistributedLanczosSolver.java 1298262 
  trunk/core/src/test/java/org/apache/mahout/math/hadoop/decomposer/TestDistributedLanczosSolverCLI.java 1298262 
  trunk/integration/src/main/java/org/apache/mahout/clustering/lda/LDAPrintTopics.java 1298262 
  trunk/integration/src/main/java/org/apache/mahout/utils/MatrixDumper.java 1298262 
  trunk/integration/src/main/java/org/apache/mahout/utils/vectors/VectorHelper.java 1298262 
  trunk/math/src/main/java/org/apache/mahout/math/decomposer/lanczos/LanczosSolver.java 1298262 
  trunk/math/src/main/java/org/apache/mahout/math/jet/stat/Gamma.java 1298262 
  trunk/math/src/main/java/org/apache/mahout/math/matrix/linalg/EigenvalueDecomposition.java 1298262 
  trunk/math/src/main/java/org/apache/mahout/math/matrix/linalg/Property.java 1298262 
  trunk/math/src/test/java/org/apache/mahout/math/MatrixTest.java 1298262 
  trunk/math/src/test/java/org/apache/mahout/math/TestSingularValueDecomposition.java 1298262 
  trunk/math/src/test/java/org/apache/mahout/math/decomposer/SolverTest.java 1298262 
  trunk/math/src/test/java/org/apache/mahout/math/decomposer/hebbian/TestHebbianSolver.java 1298262 
  trunk/math/src/test/java/org/apache/mahout/math/decomposer/lanczos/TestLanczosSolver.java 1298262 

Diff: https://reviews.apache.org/r/4238/diff


Testing
-------


Thanks,

tom


                
> Our build is unstable - this should reduce our style warnings by >200 
> ----------------------------------------------------------------------
>
>                 Key: MAHOUT-987
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-987
>             Project: Mahout
>          Issue Type: Improvement
>    Affects Versions: 0.7
>            Reporter: tom pierce
>             Fix For: 0.7
>
>         Attachments: MAHOUT-987.patch
>
>
> If we're going to keep these Jenkins style rules, let's get our build stable!
> Here's about 200 small fixes created by:
> find . -name \*java | xargs perl -pi -e 's/(if|while|for)\(/$1 (/'
> Any objections?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira