[jira] [Commented] (LUCENE-5673) MmapDirectory shouldn't pass along OOM wrapped as IOException

["Robert Muir (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-5673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999129#comment-13999129 ] 

Robert Muir commented on LUCENE-5673:
-------------------------------------

Wait, we absolutely don't want the original text. This is the whole thing that causes confusion, the whole reason I opened this issue.

The whole reason its confusing is because its "OutOfMemoryError: Map failed". Why can't it just start with "Map failed"

If you want the text to say "OutOfMemoryError", then please, unwrap the OutOfMemoryError from the IOE and throw that.

> MmapDirectory shouldn't pass along OOM wrapped as IOException
> -------------------------------------------------------------
>
>                 Key: LUCENE-5673
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5673
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-5673.patch, LUCENE-5673.patch
>
>
> The bug here is in java (not MMapDir), but i think we shoudl do something.
> Users get confused when they configure their JVM to trigger something on OOM, and then see "OutOfMemoryError: Map Failed": but their trigger doesnt fire.
> Thats because in the jdk, when it maps files it catches OutOfMemoryError, asks for a garbage collection, sleeps for 100 milliseconds, then tries to map again. if it fails a second time it wraps the OOM in a generic IOException.
> I think we should add a try/catch to our filechannel.map



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org