You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/07/11 15:48:44 UTC
[GitHub] [kafka] fvaleri opened a new pull request, #12401: Minor: replace .kafka with .log in implementation documentation
fvaleri opened a new pull request, #12401:
URL: https://github.com/apache/kafka/pull/12401
This is a minor change required to align the documentation to the current implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] fvaleri commented on pull request #12401: Minor: replace .kafka with .log in implementation documentation
Posted by GitBox <gi...@apache.org>.
fvaleri commented on PR #12401:
URL: https://github.com/apache/kafka/pull/12401#issuecomment-1190050259
> > I think that's redundant information and most of the other images don't have a title. That said, I'm not against adding it back, it's just a matter of preference.
>
> Yes, I agree. But I'd like to keep title as before, because it might have some meaning there that we don't know.
OK, done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #12401: Minor: replace .kafka with .log in implementation documentation
Posted by GitBox <gi...@apache.org>.
showuon commented on PR #12401:
URL: https://github.com/apache/kafka/pull/12401#issuecomment-1183039445
Nice catch! One question: the original image has "kafka log implementation" title on top of it. Did you intend to remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #12401: Minor: replace .kafka with .log in implementation documentation
Posted by GitBox <gi...@apache.org>.
showuon commented on PR #12401:
URL: https://github.com/apache/kafka/pull/12401#issuecomment-1190089583
Only doc change, so don't need to worry about test results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] fvaleri commented on pull request #12401: Minor: replace .kafka with .log in implementation documentation
Posted by GitBox <gi...@apache.org>.
fvaleri commented on PR #12401:
URL: https://github.com/apache/kafka/pull/12401#issuecomment-1183073005
> Nice catch! One question: the original image has "kafka log implementation" title on top of it. Did you intend to remove it?
I think that's redundant information and most of the other images don't have a title. That said, I'm not against adding it back, it's just a matter of preference.
> Also, in the image, it should be "my-topic-0/344...log", right? Not sure if this image should be consistent with the "my-topic" name. Or at least, there should be appending the partition index at the end of topic, ex: "topic-0/344...log", right?
This an image that can be easily reused in similar contexts, even externally. It's pretty hard to make it consistent with text, so I'm only addressing Kafka implementation consistency here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] fvaleri commented on pull request #12401: Minor: replace .kafka with .log in implementation documentation
Posted by GitBox <gi...@apache.org>.
fvaleri commented on PR #12401:
URL: https://github.com/apache/kafka/pull/12401#issuecomment-1188894824
@showuon is it fine? Do you have any more feedback on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #12401: Minor: replace .kafka with .log in implementation documentation
Posted by GitBox <gi...@apache.org>.
showuon commented on PR #12401:
URL: https://github.com/apache/kafka/pull/12401#issuecomment-1183042772
Also, in the image, it should be "my-topic-0/344...log", right? Not sure if this image should be consistent with the "my-topic" name. Or at least, there should be appending the partition index at the end of topic, ex: "topic-0/344...log", right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon merged pull request #12401: Minor: replace .kafka with .log in implementation documentation
Posted by GitBox <gi...@apache.org>.
showuon merged PR #12401:
URL: https://github.com/apache/kafka/pull/12401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #12401: Minor: replace .kafka with .log in implementation documentation
Posted by GitBox <gi...@apache.org>.
showuon commented on PR #12401:
URL: https://github.com/apache/kafka/pull/12401#issuecomment-1190003899
> I think that's redundant information and most of the other images don't have a title. That said, I'm not against adding it back, it's just a matter of preference.
Yes, I agree. But I'd like to keep title as before, because it might have some meaning there that we don't know.
> This an image that can be easily reused in similar contexts, even externally. It's pretty hard to make it consistent with text, so I'm only addressing Kafka implementation consistency here.
SGTM. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org