[GitHub] commons-imaging issue #37: ICNS: missing element types; some safety checks

[kinow <gi...@git.apache.org>]

Github user kinow commented on the issue:

    https://github.com/apache/commons-imaging/pull/37
  
    >As much as I love tests I'm not sure how to proceed. So what do you think?
    
    Maybe it we could get at least one or two tests, maybe using that `groovy-1.7.5/bin/groovy.icns` file? That'd be enough to include the new code IMO. But without any tests, either myself or another developer would have to write tests for it later, which would be much harder.
    
    Right now my main focus is getting everything sorted for the 1.0 release. If we can't get tests for this, I would still like to use this contribution, but would move it to 1.1 or later, until I have time to write the unit tests :+1: 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org