You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/27 08:14:44 UTC
[GitHub] [flink] wsry opened a new pull request #12994: [FLINK-18728][network] Make initialCredit of RemoteInputChannel final
wsry opened a new pull request #12994:
URL: https://github.com/apache/flink/pull/12994
## What is the purpose of the change
The filed initialCredit of RemoteInputChannel is set only once and can be accessed by multi threads. This patch makes the filed final and moves the initialization to the constructor of RemoteInputChannel to avoid potential thread safety issues.
## Brief change log
- Make initialCredit of RemoteInputChannel final
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12994: [FLINK-18728][network] Make initialCredit of RemoteInputChannel final
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12994:
URL: https://github.com/apache/flink/pull/12994#issuecomment-664206728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12994: [FLINK-18728][network] Make initialCredit of RemoteInputChannel final
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12994:
URL: https://github.com/apache/flink/pull/12994#issuecomment-664206728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4918",
"triggerID" : "a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92",
"triggerType" : "PUSH"
}, {
"hash" : "20ea916ccc154c7d53d40d273b346533b8409b12",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4934",
"triggerID" : "20ea916ccc154c7d53d40d273b346533b8409b12",
"triggerType" : "PUSH"
}, {
"hash" : "e254b80defcac6316bc542918d382159c2ebda5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4948",
"triggerID" : "e254b80defcac6316bc542918d382159c2ebda5e",
"triggerType" : "PUSH"
}, {
"hash" : "d164d2a94a4fa87a9f56f7238512d79134a722ee",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4981",
"triggerID" : "d164d2a94a4fa87a9f56f7238512d79134a722ee",
"triggerType" : "PUSH"
}, {
"hash" : "2efaa69c5791a59239feec7c122ba4fd39462238",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4985",
"triggerID" : "2efaa69c5791a59239feec7c122ba4fd39462238",
"triggerType" : "PUSH"
}, {
"hash" : "2aab77e658b25b810fcbc29c5977e16cb375c759",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5267",
"triggerID" : "2aab77e658b25b810fcbc29c5977e16cb375c759",
"triggerType" : "PUSH"
}, {
"hash" : "511d2dba850a677f5297ff75c6a911ed56efbacd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5277",
"triggerID" : "511d2dba850a677f5297ff75c6a911ed56efbacd",
"triggerType" : "PUSH"
}, {
"hash" : "707c67f554cf59d2ba1e848e05cef0aea1fe7a89",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5280",
"triggerID" : "707c67f554cf59d2ba1e848e05cef0aea1fe7a89",
"triggerType" : "PUSH"
}, {
"hash" : "370e0fc44226f5a616c459cc68d51cf6a3686991",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5314",
"triggerID" : "370e0fc44226f5a616c459cc68d51cf6a3686991",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 707c67f554cf59d2ba1e848e05cef0aea1fe7a89 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5280)
* 370e0fc44226f5a616c459cc68d51cf6a3686991 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5314)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12994: [FLINK-18728][network] Make initialCredit of RemoteInputChannel final
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12994:
URL: https://github.com/apache/flink/pull/12994#issuecomment-664206728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4918",
"triggerID" : "a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92",
"triggerType" : "PUSH"
}, {
"hash" : "20ea916ccc154c7d53d40d273b346533b8409b12",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4934",
"triggerID" : "20ea916ccc154c7d53d40d273b346533b8409b12",
"triggerType" : "PUSH"
}, {
"hash" : "e254b80defcac6316bc542918d382159c2ebda5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4948",
"triggerID" : "e254b80defcac6316bc542918d382159c2ebda5e",
"triggerType" : "PUSH"
}, {
"hash" : "d164d2a94a4fa87a9f56f7238512d79134a722ee",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4981",
"triggerID" : "d164d2a94a4fa87a9f56f7238512d79134a722ee",
"triggerType" : "PUSH"
}, {
"hash" : "2efaa69c5791a59239feec7c122ba4fd39462238",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4985",
"triggerID" : "2efaa69c5791a59239feec7c122ba4fd39462238",
"triggerType" : "PUSH"
}, {
"hash" : "2aab77e658b25b810fcbc29c5977e16cb375c759",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5267",
"triggerID" : "2aab77e658b25b810fcbc29c5977e16cb375c759",
"triggerType" : "PUSH"
}, {
"hash" : "511d2dba850a677f5297ff75c6a911ed56efbacd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "511d2dba850a677f5297ff75c6a911ed56efbacd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2aab77e658b25b810fcbc29c5977e16cb375c759 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5267)
* 511d2dba850a677f5297ff75c6a911ed56efbacd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12994: [FLINK-18728][network] Make initialCredit of RemoteInputChannel final
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12994:
URL: https://github.com/apache/flink/pull/12994#issuecomment-664206728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4918",
"triggerID" : "a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4918)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12994: [FLINK-18728][network] Make initialCredit of RemoteInputChannel final
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12994:
URL: https://github.com/apache/flink/pull/12994#issuecomment-664206728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4918",
"triggerID" : "a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92",
"triggerType" : "PUSH"
}, {
"hash" : "20ea916ccc154c7d53d40d273b346533b8409b12",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4934",
"triggerID" : "20ea916ccc154c7d53d40d273b346533b8409b12",
"triggerType" : "PUSH"
}, {
"hash" : "e254b80defcac6316bc542918d382159c2ebda5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4948",
"triggerID" : "e254b80defcac6316bc542918d382159c2ebda5e",
"triggerType" : "PUSH"
}, {
"hash" : "d164d2a94a4fa87a9f56f7238512d79134a722ee",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4981",
"triggerID" : "d164d2a94a4fa87a9f56f7238512d79134a722ee",
"triggerType" : "PUSH"
}, {
"hash" : "2efaa69c5791a59239feec7c122ba4fd39462238",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4985",
"triggerID" : "2efaa69c5791a59239feec7c122ba4fd39462238",
"triggerType" : "PUSH"
}, {
"hash" : "2aab77e658b25b810fcbc29c5977e16cb375c759",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5267",
"triggerID" : "2aab77e658b25b810fcbc29c5977e16cb375c759",
"triggerType" : "PUSH"
}, {
"hash" : "511d2dba850a677f5297ff75c6a911ed56efbacd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5277",
"triggerID" : "511d2dba850a677f5297ff75c6a911ed56efbacd",
"triggerType" : "PUSH"
}, {
"hash" : "707c67f554cf59d2ba1e848e05cef0aea1fe7a89",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5280",
"triggerID" : "707c67f554cf59d2ba1e848e05cef0aea1fe7a89",
"triggerType" : "PUSH"
}, {
"hash" : "370e0fc44226f5a616c459cc68d51cf6a3686991",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5314",
"triggerID" : "370e0fc44226f5a616c459cc68d51cf6a3686991",
"triggerType" : "PUSH"
}, {
"hash" : "453eabc11a5acfbf6cca97959b6bf6e57a93b0e9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5315",
"triggerID" : "453eabc11a5acfbf6cca97959b6bf6e57a93b0e9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 707c67f554cf59d2ba1e848e05cef0aea1fe7a89 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5280)
* 370e0fc44226f5a616c459cc68d51cf6a3686991 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5314)
* 453eabc11a5acfbf6cca97959b6bf6e57a93b0e9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5315)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW merged pull request #12994: [FLINK-18728][network] Make initialCredit of RemoteInputChannel final
Posted by GitBox <gi...@apache.org>.
zhijiangW merged pull request #12994:
URL: https://github.com/apache/flink/pull/12994
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW commented on pull request #12994: [FLINK-18728][network] Make initialCredit of RemoteInputChannel final
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on pull request #12994:
URL: https://github.com/apache/flink/pull/12994#issuecomment-669828599
Thanks for the improvement @wsry , the codes look good to me. Only left one comment for further improvement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12994: [FLINK-18728][network] Make initialCredit of RemoteInputChannel final
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12994:
URL: https://github.com/apache/flink/pull/12994#issuecomment-664206728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4918",
"triggerID" : "a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92",
"triggerType" : "PUSH"
}, {
"hash" : "20ea916ccc154c7d53d40d273b346533b8409b12",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4934",
"triggerID" : "20ea916ccc154c7d53d40d273b346533b8409b12",
"triggerType" : "PUSH"
}, {
"hash" : "e254b80defcac6316bc542918d382159c2ebda5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4948",
"triggerID" : "e254b80defcac6316bc542918d382159c2ebda5e",
"triggerType" : "PUSH"
}, {
"hash" : "d164d2a94a4fa87a9f56f7238512d79134a722ee",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4981",
"triggerID" : "d164d2a94a4fa87a9f56f7238512d79134a722ee",
"triggerType" : "PUSH"
}, {
"hash" : "2efaa69c5791a59239feec7c122ba4fd39462238",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4985",
"triggerID" : "2efaa69c5791a59239feec7c122ba4fd39462238",
"triggerType" : "PUSH"
}, {
"hash" : "2aab77e658b25b810fcbc29c5977e16cb375c759",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5267",
"triggerID" : "2aab77e658b25b810fcbc29c5977e16cb375c759",
"triggerType" : "PUSH"
}, {
"hash" : "511d2dba850a677f5297ff75c6a911ed56efbacd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5277",
"triggerID" : "511d2dba850a677f5297ff75c6a911ed56efbacd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 511d2dba850a677f5297ff75c6a911ed56efbacd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5277)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12994: [FLINK-18728][network] Make initialCredit of RemoteInputChannel final
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12994:
URL: https://github.com/apache/flink/pull/12994#issuecomment-664206728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4918",
"triggerID" : "a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92",
"triggerType" : "PUSH"
}, {
"hash" : "20ea916ccc154c7d53d40d273b346533b8409b12",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4934",
"triggerID" : "20ea916ccc154c7d53d40d273b346533b8409b12",
"triggerType" : "PUSH"
}, {
"hash" : "e254b80defcac6316bc542918d382159c2ebda5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4948",
"triggerID" : "e254b80defcac6316bc542918d382159c2ebda5e",
"triggerType" : "PUSH"
}, {
"hash" : "d164d2a94a4fa87a9f56f7238512d79134a722ee",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4981",
"triggerID" : "d164d2a94a4fa87a9f56f7238512d79134a722ee",
"triggerType" : "PUSH"
}, {
"hash" : "2efaa69c5791a59239feec7c122ba4fd39462238",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4985",
"triggerID" : "2efaa69c5791a59239feec7c122ba4fd39462238",
"triggerType" : "PUSH"
}, {
"hash" : "2aab77e658b25b810fcbc29c5977e16cb375c759",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5267",
"triggerID" : "2aab77e658b25b810fcbc29c5977e16cb375c759",
"triggerType" : "PUSH"
}, {
"hash" : "511d2dba850a677f5297ff75c6a911ed56efbacd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5277",
"triggerID" : "511d2dba850a677f5297ff75c6a911ed56efbacd",
"triggerType" : "PUSH"
}, {
"hash" : "707c67f554cf59d2ba1e848e05cef0aea1fe7a89",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5280",
"triggerID" : "707c67f554cf59d2ba1e848e05cef0aea1fe7a89",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 707c67f554cf59d2ba1e848e05cef0aea1fe7a89 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5280)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12994: [FLINK-18728][network] Make initialCredit of RemoteInputChannel final
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12994:
URL: https://github.com/apache/flink/pull/12994#issuecomment-664206728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4918",
"triggerID" : "a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92",
"triggerType" : "PUSH"
}, {
"hash" : "20ea916ccc154c7d53d40d273b346533b8409b12",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4934",
"triggerID" : "20ea916ccc154c7d53d40d273b346533b8409b12",
"triggerType" : "PUSH"
}, {
"hash" : "e254b80defcac6316bc542918d382159c2ebda5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4948",
"triggerID" : "e254b80defcac6316bc542918d382159c2ebda5e",
"triggerType" : "PUSH"
}, {
"hash" : "d164d2a94a4fa87a9f56f7238512d79134a722ee",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4981",
"triggerID" : "d164d2a94a4fa87a9f56f7238512d79134a722ee",
"triggerType" : "PUSH"
}, {
"hash" : "2efaa69c5791a59239feec7c122ba4fd39462238",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4985",
"triggerID" : "2efaa69c5791a59239feec7c122ba4fd39462238",
"triggerType" : "PUSH"
}, {
"hash" : "2aab77e658b25b810fcbc29c5977e16cb375c759",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5267",
"triggerID" : "2aab77e658b25b810fcbc29c5977e16cb375c759",
"triggerType" : "PUSH"
}, {
"hash" : "511d2dba850a677f5297ff75c6a911ed56efbacd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5277",
"triggerID" : "511d2dba850a677f5297ff75c6a911ed56efbacd",
"triggerType" : "PUSH"
}, {
"hash" : "707c67f554cf59d2ba1e848e05cef0aea1fe7a89",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5280",
"triggerID" : "707c67f554cf59d2ba1e848e05cef0aea1fe7a89",
"triggerType" : "PUSH"
}, {
"hash" : "370e0fc44226f5a616c459cc68d51cf6a3686991",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5314",
"triggerID" : "370e0fc44226f5a616c459cc68d51cf6a3686991",
"triggerType" : "PUSH"
}, {
"hash" : "453eabc11a5acfbf6cca97959b6bf6e57a93b0e9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "453eabc11a5acfbf6cca97959b6bf6e57a93b0e9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 707c67f554cf59d2ba1e848e05cef0aea1fe7a89 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5280)
* 370e0fc44226f5a616c459cc68d51cf6a3686991 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5314)
* 453eabc11a5acfbf6cca97959b6bf6e57a93b0e9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wsry commented on pull request #12994: [FLINK-18728][network] Make initialCredit of RemoteInputChannel final
Posted by GitBox <gi...@apache.org>.
wsry commented on pull request #12994:
URL: https://github.com/apache/flink/pull/12994#issuecomment-673379243
The failed e2e test should be irrelevant, all tests passed on my private pipeline: https://dev.azure.com/kevin-flink/flink/_build/results?buildId=56&view=results
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12994: [FLINK-18728][network] Make initialCredit of RemoteInputChannel final
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12994:
URL: https://github.com/apache/flink/pull/12994#issuecomment-664206728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4918",
"triggerID" : "a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92",
"triggerType" : "PUSH"
}, {
"hash" : "20ea916ccc154c7d53d40d273b346533b8409b12",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4934",
"triggerID" : "20ea916ccc154c7d53d40d273b346533b8409b12",
"triggerType" : "PUSH"
}, {
"hash" : "e254b80defcac6316bc542918d382159c2ebda5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4948",
"triggerID" : "e254b80defcac6316bc542918d382159c2ebda5e",
"triggerType" : "PUSH"
}, {
"hash" : "d164d2a94a4fa87a9f56f7238512d79134a722ee",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4981",
"triggerID" : "d164d2a94a4fa87a9f56f7238512d79134a722ee",
"triggerType" : "PUSH"
}, {
"hash" : "2efaa69c5791a59239feec7c122ba4fd39462238",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4985",
"triggerID" : "2efaa69c5791a59239feec7c122ba4fd39462238",
"triggerType" : "PUSH"
}, {
"hash" : "2aab77e658b25b810fcbc29c5977e16cb375c759",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5267",
"triggerID" : "2aab77e658b25b810fcbc29c5977e16cb375c759",
"triggerType" : "PUSH"
}, {
"hash" : "511d2dba850a677f5297ff75c6a911ed56efbacd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5277",
"triggerID" : "511d2dba850a677f5297ff75c6a911ed56efbacd",
"triggerType" : "PUSH"
}, {
"hash" : "707c67f554cf59d2ba1e848e05cef0aea1fe7a89",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5280",
"triggerID" : "707c67f554cf59d2ba1e848e05cef0aea1fe7a89",
"triggerType" : "PUSH"
}, {
"hash" : "370e0fc44226f5a616c459cc68d51cf6a3686991",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5314",
"triggerID" : "370e0fc44226f5a616c459cc68d51cf6a3686991",
"triggerType" : "PUSH"
}, {
"hash" : "453eabc11a5acfbf6cca97959b6bf6e57a93b0e9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5315",
"triggerID" : "453eabc11a5acfbf6cca97959b6bf6e57a93b0e9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 370e0fc44226f5a616c459cc68d51cf6a3686991 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5314)
* 453eabc11a5acfbf6cca97959b6bf6e57a93b0e9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5315)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12994: [FLINK-18728][network] Make initialCredit of RemoteInputChannel final
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12994:
URL: https://github.com/apache/flink/pull/12994#issuecomment-664206728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4918",
"triggerID" : "a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92",
"triggerType" : "PUSH"
}, {
"hash" : "20ea916ccc154c7d53d40d273b346533b8409b12",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4934",
"triggerID" : "20ea916ccc154c7d53d40d273b346533b8409b12",
"triggerType" : "PUSH"
}, {
"hash" : "e254b80defcac6316bc542918d382159c2ebda5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4948",
"triggerID" : "e254b80defcac6316bc542918d382159c2ebda5e",
"triggerType" : "PUSH"
}, {
"hash" : "d164d2a94a4fa87a9f56f7238512d79134a722ee",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4981",
"triggerID" : "d164d2a94a4fa87a9f56f7238512d79134a722ee",
"triggerType" : "PUSH"
}, {
"hash" : "2efaa69c5791a59239feec7c122ba4fd39462238",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4985",
"triggerID" : "2efaa69c5791a59239feec7c122ba4fd39462238",
"triggerType" : "PUSH"
}, {
"hash" : "2aab77e658b25b810fcbc29c5977e16cb375c759",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5267",
"triggerID" : "2aab77e658b25b810fcbc29c5977e16cb375c759",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2aab77e658b25b810fcbc29c5977e16cb375c759 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5267)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12994: [FLINK-18728][network] Make initialCredit of RemoteInputChannel final
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12994:
URL: https://github.com/apache/flink/pull/12994#issuecomment-664206728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4918",
"triggerID" : "a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92",
"triggerType" : "PUSH"
}, {
"hash" : "20ea916ccc154c7d53d40d273b346533b8409b12",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4934",
"triggerID" : "20ea916ccc154c7d53d40d273b346533b8409b12",
"triggerType" : "PUSH"
}, {
"hash" : "e254b80defcac6316bc542918d382159c2ebda5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4948",
"triggerID" : "e254b80defcac6316bc542918d382159c2ebda5e",
"triggerType" : "PUSH"
}, {
"hash" : "d164d2a94a4fa87a9f56f7238512d79134a722ee",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4981",
"triggerID" : "d164d2a94a4fa87a9f56f7238512d79134a722ee",
"triggerType" : "PUSH"
}, {
"hash" : "2efaa69c5791a59239feec7c122ba4fd39462238",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4985",
"triggerID" : "2efaa69c5791a59239feec7c122ba4fd39462238",
"triggerType" : "PUSH"
}, {
"hash" : "2aab77e658b25b810fcbc29c5977e16cb375c759",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2aab77e658b25b810fcbc29c5977e16cb375c759",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2efaa69c5791a59239feec7c122ba4fd39462238 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4985)
* 2aab77e658b25b810fcbc29c5977e16cb375c759 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW commented on a change in pull request #12994: [FLINK-18728][network] Make initialCredit of RemoteInputChannel final
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #12994:
URL: https://github.com/apache/flink/pull/12994#discussion_r466927353
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/NetworkBufferPool.java
##########
@@ -161,13 +155,13 @@ public void recycle(MemorySegment segment) {
}
@Override
- public List<MemorySegment> requestMemorySegments() throws IOException {
+ public List<MemorySegment> requestMemorySegments(int numberOfSegmentsToRequest) throws IOException {
Review comment:
Do you think we should check the passed argument more than `0` in advance?
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java
##########
@@ -1121,14 +1118,15 @@ public void testUnblockReleasedChannel() throws Exception {
remoteChannel.resumeConsumption();
}
- // ---------------------------------------------------------------------------------------------
-
- public static RemoteInputChannel createRemoteInputChannel(SingleInputGate inputGate, int numExclusiveSegments) {
- return InputChannelBuilder.newBuilder()
- .setNetworkBuffersPerChannel(numExclusiveSegments)
- .buildRemoteChannel(inputGate);
+ @Test(expected = IllegalStateException.class)
+ public void testIllegalNumberOfExclusiveBuffers() throws Exception {
Review comment:
I guess this test should be adjusted as well based on above comments.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -128,8 +128,9 @@ public RemoteInputChannel(
void assignExclusiveSegments() throws IOException {
checkState(bufferManager.unsynchronizedGetAvailableExclusiveBuffers() == 0,
"Bug in input channel setup logic: exclusive buffers have already been set for this input channel.");
+ checkState(initialCredit > 0, "Number of exclusive buffers must be larger than 0.");
Review comment:
nit: if we want to check this argument, it would be better to be done in the initialization of constructor.
I think we can remove it directly since the passed `networkBuffersPerChannel` in constructor should already be checked in previous component.
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java
##########
@@ -1121,14 +1118,15 @@ public void testUnblockReleasedChannel() throws Exception {
remoteChannel.resumeConsumption();
}
- // ---------------------------------------------------------------------------------------------
-
- public static RemoteInputChannel createRemoteInputChannel(SingleInputGate inputGate, int numExclusiveSegments) {
Review comment:
This change seems unnecessary?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12994: [FLINK-18728][network] Make initialCredit of RemoteInputChannel final
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12994:
URL: https://github.com/apache/flink/pull/12994#issuecomment-664206728
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12994: [FLINK-18728][network] Make initialCredit of RemoteInputChannel final
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12994:
URL: https://github.com/apache/flink/pull/12994#issuecomment-664206728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4918",
"triggerID" : "a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92",
"triggerType" : "PUSH"
}, {
"hash" : "20ea916ccc154c7d53d40d273b346533b8409b12",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4934",
"triggerID" : "20ea916ccc154c7d53d40d273b346533b8409b12",
"triggerType" : "PUSH"
}, {
"hash" : "e254b80defcac6316bc542918d382159c2ebda5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4948",
"triggerID" : "e254b80defcac6316bc542918d382159c2ebda5e",
"triggerType" : "PUSH"
}, {
"hash" : "d164d2a94a4fa87a9f56f7238512d79134a722ee",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4981",
"triggerID" : "d164d2a94a4fa87a9f56f7238512d79134a722ee",
"triggerType" : "PUSH"
}, {
"hash" : "2efaa69c5791a59239feec7c122ba4fd39462238",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4985",
"triggerID" : "2efaa69c5791a59239feec7c122ba4fd39462238",
"triggerType" : "PUSH"
}, {
"hash" : "2aab77e658b25b810fcbc29c5977e16cb375c759",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5267",
"triggerID" : "2aab77e658b25b810fcbc29c5977e16cb375c759",
"triggerType" : "PUSH"
}, {
"hash" : "511d2dba850a677f5297ff75c6a911ed56efbacd",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5277",
"triggerID" : "511d2dba850a677f5297ff75c6a911ed56efbacd",
"triggerType" : "PUSH"
}, {
"hash" : "707c67f554cf59d2ba1e848e05cef0aea1fe7a89",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5280",
"triggerID" : "707c67f554cf59d2ba1e848e05cef0aea1fe7a89",
"triggerType" : "PUSH"
}, {
"hash" : "370e0fc44226f5a616c459cc68d51cf6a3686991",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "370e0fc44226f5a616c459cc68d51cf6a3686991",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 707c67f554cf59d2ba1e848e05cef0aea1fe7a89 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5280)
* 370e0fc44226f5a616c459cc68d51cf6a3686991 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12994: [FLINK-18728][network] Make initialCredit of RemoteInputChannel final
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12994:
URL: https://github.com/apache/flink/pull/12994#issuecomment-664206728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4918",
"triggerID" : "a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92",
"triggerType" : "PUSH"
}, {
"hash" : "20ea916ccc154c7d53d40d273b346533b8409b12",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4934",
"triggerID" : "20ea916ccc154c7d53d40d273b346533b8409b12",
"triggerType" : "PUSH"
}, {
"hash" : "e254b80defcac6316bc542918d382159c2ebda5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4948",
"triggerID" : "e254b80defcac6316bc542918d382159c2ebda5e",
"triggerType" : "PUSH"
}, {
"hash" : "d164d2a94a4fa87a9f56f7238512d79134a722ee",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4981",
"triggerID" : "d164d2a94a4fa87a9f56f7238512d79134a722ee",
"triggerType" : "PUSH"
}, {
"hash" : "2efaa69c5791a59239feec7c122ba4fd39462238",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4985",
"triggerID" : "2efaa69c5791a59239feec7c122ba4fd39462238",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2efaa69c5791a59239feec7c122ba4fd39462238 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4985)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12994: [FLINK-18728][network] Make initialCredit of RemoteInputChannel final
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12994:
URL: https://github.com/apache/flink/pull/12994#issuecomment-664206728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4918",
"triggerID" : "a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92",
"triggerType" : "PUSH"
}, {
"hash" : "20ea916ccc154c7d53d40d273b346533b8409b12",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4934",
"triggerID" : "20ea916ccc154c7d53d40d273b346533b8409b12",
"triggerType" : "PUSH"
}, {
"hash" : "e254b80defcac6316bc542918d382159c2ebda5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4948",
"triggerID" : "e254b80defcac6316bc542918d382159c2ebda5e",
"triggerType" : "PUSH"
}, {
"hash" : "d164d2a94a4fa87a9f56f7238512d79134a722ee",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4981",
"triggerID" : "d164d2a94a4fa87a9f56f7238512d79134a722ee",
"triggerType" : "PUSH"
}, {
"hash" : "2efaa69c5791a59239feec7c122ba4fd39462238",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4985",
"triggerID" : "2efaa69c5791a59239feec7c122ba4fd39462238",
"triggerType" : "PUSH"
}, {
"hash" : "2aab77e658b25b810fcbc29c5977e16cb375c759",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5267",
"triggerID" : "2aab77e658b25b810fcbc29c5977e16cb375c759",
"triggerType" : "PUSH"
}, {
"hash" : "511d2dba850a677f5297ff75c6a911ed56efbacd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5277",
"triggerID" : "511d2dba850a677f5297ff75c6a911ed56efbacd",
"triggerType" : "PUSH"
}, {
"hash" : "707c67f554cf59d2ba1e848e05cef0aea1fe7a89",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5280",
"triggerID" : "707c67f554cf59d2ba1e848e05cef0aea1fe7a89",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 511d2dba850a677f5297ff75c6a911ed56efbacd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5277)
* 707c67f554cf59d2ba1e848e05cef0aea1fe7a89 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5280)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12994: [FLINK-18728][network] Make initialCredit of RemoteInputChannel final
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12994:
URL: https://github.com/apache/flink/pull/12994#issuecomment-664206728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4918",
"triggerID" : "a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92",
"triggerType" : "PUSH"
}, {
"hash" : "20ea916ccc154c7d53d40d273b346533b8409b12",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4934",
"triggerID" : "20ea916ccc154c7d53d40d273b346533b8409b12",
"triggerType" : "PUSH"
}, {
"hash" : "e254b80defcac6316bc542918d382159c2ebda5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4948",
"triggerID" : "e254b80defcac6316bc542918d382159c2ebda5e",
"triggerType" : "PUSH"
}, {
"hash" : "d164d2a94a4fa87a9f56f7238512d79134a722ee",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4981",
"triggerID" : "d164d2a94a4fa87a9f56f7238512d79134a722ee",
"triggerType" : "PUSH"
}, {
"hash" : "2efaa69c5791a59239feec7c122ba4fd39462238",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4985",
"triggerID" : "2efaa69c5791a59239feec7c122ba4fd39462238",
"triggerType" : "PUSH"
}, {
"hash" : "2aab77e658b25b810fcbc29c5977e16cb375c759",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5267",
"triggerID" : "2aab77e658b25b810fcbc29c5977e16cb375c759",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2efaa69c5791a59239feec7c122ba4fd39462238 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4985)
* 2aab77e658b25b810fcbc29c5977e16cb375c759 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5267)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12994: [FLINK-18728][network] Make initialCredit of RemoteInputChannel final
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12994:
URL: https://github.com/apache/flink/pull/12994#issuecomment-664206728
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4918",
"triggerID" : "a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92",
"triggerType" : "PUSH"
}, {
"hash" : "20ea916ccc154c7d53d40d273b346533b8409b12",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4934",
"triggerID" : "20ea916ccc154c7d53d40d273b346533b8409b12",
"triggerType" : "PUSH"
}, {
"hash" : "e254b80defcac6316bc542918d382159c2ebda5e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4948",
"triggerID" : "e254b80defcac6316bc542918d382159c2ebda5e",
"triggerType" : "PUSH"
}, {
"hash" : "d164d2a94a4fa87a9f56f7238512d79134a722ee",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4981",
"triggerID" : "d164d2a94a4fa87a9f56f7238512d79134a722ee",
"triggerType" : "PUSH"
}, {
"hash" : "2efaa69c5791a59239feec7c122ba4fd39462238",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4985",
"triggerID" : "2efaa69c5791a59239feec7c122ba4fd39462238",
"triggerType" : "PUSH"
}, {
"hash" : "2aab77e658b25b810fcbc29c5977e16cb375c759",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5267",
"triggerID" : "2aab77e658b25b810fcbc29c5977e16cb375c759",
"triggerType" : "PUSH"
}, {
"hash" : "511d2dba850a677f5297ff75c6a911ed56efbacd",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5277",
"triggerID" : "511d2dba850a677f5297ff75c6a911ed56efbacd",
"triggerType" : "PUSH"
}, {
"hash" : "707c67f554cf59d2ba1e848e05cef0aea1fe7a89",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "707c67f554cf59d2ba1e848e05cef0aea1fe7a89",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 511d2dba850a677f5297ff75c6a911ed56efbacd Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5277)
* 707c67f554cf59d2ba1e848e05cef0aea1fe7a89 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhijiangW commented on a change in pull request #12994: [FLINK-18728][network] Make initialCredit of RemoteInputChannel final
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #12994:
URL: https://github.com/apache/flink/pull/12994#discussion_r466272084
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/BufferManager.java
##########
@@ -125,9 +125,9 @@ private boolean shouldContinueRequest(BufferPool bufferPool) {
}
/**
- * Requests exclusive buffers from the provider and returns the number of requested amount.
+ * Requests exclusive buffers from the provider.
*/
- int requestExclusiveBuffers() throws IOException {
+ void requestExclusiveBuffers() throws IOException {
Collection<MemorySegment> segments = globalPool.requestMemorySegments();
Review comment:
The previous initial credit seems to be got from the returned collection size of `globalPool.requestMemorySegments()` somehow. If we can get the initial credit in advance, then it would be better to also pass it as argument into `requestMemorySegments` to get required size. To do so, the `NetworkBufferPool#requestMemorySegments` seems more general to decouple with credit semantic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12994: [FLINK-18728][network] Make initialCredit of RemoteInputChannel final
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12994:
URL: https://github.com/apache/flink/pull/12994#issuecomment-664193592
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit a031dfe63cc4494e4cb7fe599b9bcafe6ba0ce92 (Mon Jul 27 08:17:25 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-18728).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org