You are viewing a plain text version of this content. The canonical link for it is here.
Posted to doxia-dev@maven.apache.org by Lukas Theussl <lt...@apache.org> on 2007/07/22 22:51:35 UTC
Re: svn commit: r558543 - /maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/DefaultSiteRendererTest.java
I have reverted part of my commit, tests are passing now again, however,
I had to comment out a few asserts in DefaultSiteRendererTest.java. I am
not quite sure how these tests could ever have passed: eg for the
following html segment
<ul>
<li>
Item 1.
<ul>
<li>
<p>Item 11.</p>
</li>
<li>
<p>Item 12.</p>
</li>
<li>
Item 13.
</li>
<li>
Item 14.
</li>
</ul>
</li>
the expression ul.getFirstChild().asText() returns "Item 1. Item 11.
Item 12. Item 13. Item 14." , which is correct if I understand the
htmlunit javadocs correctly. But the test asserted an empty string. Am I
still missing something?
Cheers,
-Lukas
ltheussl@apache.org wrote:
> Author: ltheussl
> Date: Sun Jul 22 13:38:24 2007
> New Revision: 558543
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=558543
> Log:
> Comment out failing tests, - need to clarify.
>
> Modified:
> maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/DefaultSiteRendererTest.java
>
> Modified: maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/DefaultSiteRendererTest.java
> URL: http://svn.apache.org/viewvc/maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/DefaultSiteRendererTest.java?view=diff&rev=558543&r1=558542&r2=558543
> ==============================================================================
> --- maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/DefaultSiteRendererTest.java (original)
> +++ maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/DefaultSiteRendererTest.java Sun Jul 22 13:38:24 2007
> @@ -176,7 +176,8 @@
>
> HtmlUnorderedList ul = (HtmlUnorderedList) elementIterator.next();
> assertNotNull( ul );
> - assertEquals( ul.getFirstChild().asText(), "" );
> + // TODO: how can this be?
> + //assertEquals( ul.getFirstChild().asText(), "" );
>
Re: svn commit: r558543 - /maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/DefaultSiteRendererTest.java
Posted by Lukas Theussl <lt...@apache.org>.
I can confirm that my layout is the same as yours, I only formatted it
for the mail, not thinking it would be important for htmlunit. But if
the tests depend on the formatting then it's probably best to disable
them anyway..
Thanks,
-Lukas
Vincent Siveton wrote:
> Hi again,
>
> 2007/7/22, Lukas Theussl <lt...@apache.org>:
>
>> I have reverted part of my commit, tests are passing now again, however,
>
>
> Thanks!
>
>> I had to comment out a few asserts in DefaultSiteRendererTest.java. I am
>> not quite sure how these tests could ever have passed: eg for the
>> following html segment
>>
>> <ul>
>> <li>
>> Item 1.
>> <ul>
>> <li>
>> <p>Item 11.</p>
>> </li>
>> <li>
>> <p>Item 12.</p>
>> </li>
>> <li>
>> Item 13.
>> </li>
>> <li>
>> Item 14.
>> </li>
>> </ul>
>> </li>
>
>
> IIRC, this html snippet was generated like this in the past. Now, it
> is without well done indentation on my side, ie
>
> </p><ul><li>
> Item 1.
> <ul><li>Item 11.</li><li>Item 12.</li><li>
> Item 13.
> </li><li>
> Item 14.
> </li></ul></li>
>
>> the expression ul.getFirstChild().asText() returns "Item 1. Item 11.
>> Item 12. Item 13. Item 14." , which is correct if I understand the
>> htmlunit javadocs correctly. But the test asserted an empty string. Am I
>> still missing something?
>
>
> Agree but if you confirm the indentation pb on your side, I think that
> httpunit doesnt handle the carriage return well.
>
> Cheers,
>
> Vincent
>
>> Cheers,
>> -Lukas
>>
>>
>> ltheussl@apache.org wrote:
>> > Author: ltheussl
>> > Date: Sun Jul 22 13:38:24 2007
>> > New Revision: 558543
>> >
>> > URL: http://svn.apache.org/viewvc?view=rev&rev=558543
>> > Log:
>> > Comment out failing tests, - need to clarify.
>> >
>> > Modified:
>> >
>> maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/DefaultSiteRendererTest.java
>>
>> >
>> > Modified:
>> maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/DefaultSiteRendererTest.java
>>
>> > URL:
>> http://svn.apache.org/viewvc/maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/DefaultSiteRendererTest.java?view=diff&rev=558543&r1=558542&r2=558543
>>
>> >
>> ==============================================================================
>>
>> > ---
>> maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/DefaultSiteRendererTest.java
>> (original)
>> > +++
>> maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/DefaultSiteRendererTest.java
>> Sun Jul 22 13:38:24 2007
>> > @@ -176,7 +176,8 @@
>> >
>> > HtmlUnorderedList ul = (HtmlUnorderedList)
>> elementIterator.next();
>> > assertNotNull( ul );
>> > - assertEquals( ul.getFirstChild().asText(), "" );
>> > + // TODO: how can this be?
>> > + //assertEquals( ul.getFirstChild().asText(), "" );
>> >
>>
>>
Re: svn commit: r558543 - /maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/DefaultSiteRendererTest.java
Posted by Vincent Siveton <vi...@gmail.com>.
Hi again,
2007/7/22, Lukas Theussl <lt...@apache.org>:
> I have reverted part of my commit, tests are passing now again, however,
Thanks!
> I had to comment out a few asserts in DefaultSiteRendererTest.java. I am
> not quite sure how these tests could ever have passed: eg for the
> following html segment
>
> <ul>
> <li>
> Item 1.
> <ul>
> <li>
> <p>Item 11.</p>
> </li>
> <li>
> <p>Item 12.</p>
> </li>
> <li>
> Item 13.
> </li>
> <li>
> Item 14.
> </li>
> </ul>
> </li>
IIRC, this html snippet was generated like this in the past. Now, it
is without well done indentation on my side, ie
</p><ul><li>
Item 1.
<ul><li>Item 11.</li><li>Item 12.</li><li>
Item 13.
</li><li>
Item 14.
</li></ul></li>
> the expression ul.getFirstChild().asText() returns "Item 1. Item 11.
> Item 12. Item 13. Item 14." , which is correct if I understand the
> htmlunit javadocs correctly. But the test asserted an empty string. Am I
> still missing something?
Agree but if you confirm the indentation pb on your side, I think that
httpunit doesnt handle the carriage return well.
Cheers,
Vincent
> Cheers,
> -Lukas
>
>
> ltheussl@apache.org wrote:
> > Author: ltheussl
> > Date: Sun Jul 22 13:38:24 2007
> > New Revision: 558543
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=558543
> > Log:
> > Comment out failing tests, - need to clarify.
> >
> > Modified:
> > maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/DefaultSiteRendererTest.java
> >
> > Modified: maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/DefaultSiteRendererTest.java
> > URL: http://svn.apache.org/viewvc/maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/DefaultSiteRendererTest.java?view=diff&rev=558543&r1=558542&r2=558543
> > ==============================================================================
> > --- maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/DefaultSiteRendererTest.java (original)
> > +++ maven/doxia/doxia-sitetools/trunk/doxia-site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/DefaultSiteRendererTest.java Sun Jul 22 13:38:24 2007
> > @@ -176,7 +176,8 @@
> >
> > HtmlUnorderedList ul = (HtmlUnorderedList) elementIterator.next();
> > assertNotNull( ul );
> > - assertEquals( ul.getFirstChild().asText(), "" );
> > + // TODO: how can this be?
> > + //assertEquals( ul.getFirstChild().asText(), "" );
> >
>
>