[GitHub] [superset] michael-s-molina commented on a diff in pull request #20728: feat(dashboard): Add Drill to Detail modal w/ chart menu + right-click support

[GitBox <gi...@apache.org>]

michael-s-molina commented on code in PR #20728:
URL: https://github.com/apache/superset/pull/20728#discussion_r943387450


##########
superset-frontend/plugins/plugin-chart-echarts/src/Gauge/EchartsGauge.tsx:
##########
@@ -77,7 +77,7 @@ export default function EchartsGauge({
         const pointerEvent = e.event.event;
         const filters: QueryObjectFilterClause[] = [];
         if (groupby.length > 0) {
-          const values = e.name.split(',');

Review Comment:
   If you mean that we have single values with a dangling comma at the end, then your code will fix it. However, if we have values with commas then we need to use a different separator. Let me know which one is it and if it's the separator case then I can open a PR to fix it for all charts.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org