You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/14 05:38:44 UTC

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #7919: ARROW-9678: [Rust] [DataFusion] Improve projection push down to remove unused columns

jorgecarleitao commented on a change in pull request #7919:
URL: https://github.com/apache/arrow/pull/7919#discussion_r470420151



##########
File path: rust/datafusion/src/optimizer/projection_push_down.rs
##########
@@ -45,116 +48,12 @@ impl ProjectionPushDown {
     pub fn new() -> Self {
         Self {}
     }
-
-    fn optimize_plan(

Review comment:
       This just moves the function to outside `ProjectionPushDown`, since it does not really depend on the state of `ProjectionPushDown`, i.e. it can be written as a normal function.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org