You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/01/27 21:20:48 UTC
[GitHub] [commons-jexl] davidcostanzo opened a new pull request #20:
JEXL-324 - Change grammar to make "new" require at least one argument
davidcostanzo opened a new pull request #20: JEXL-324 - Change grammar to make "new" require at least one argument
URL: https://github.com/apache/commons-jexl/pull/20
This PR changes the JEXL grammar to force "new" to require at least one argument. It also includes one new test case to cover the newly illegal syntax (new with arguments is already covered, but more coverage could be added if desired).
Another way to fix the NPE described in JEXL-324 would be to keep the grammar as-is, but tolerate new without any arguments within the Debugger class. This would have less of a compatibility impact.
This is my first PR to the JEXL project. I'm open to criticism.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-jexl] henrib closed pull request #20: JEXL-324 - Change
grammar to make "new" require at least one argument
Posted by GitBox <gi...@apache.org>.
henrib closed pull request #20: JEXL-324 - Change grammar to make "new" require at least one argument
URL: https://github.com/apache/commons-jexl/pull/20
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services