You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/02/20 09:23:59 UTC
[GitHub] [cloudstack] ustcweizhou opened a new pull request #3898: vrouter:
reload keepalived instead of restart and fix password server issues when
add/remove vpc tier
ustcweizhou opened a new pull request #3898: vrouter: reload keepalived instead of restart and fix password server issues when add/remove vpc tier
URL: https://github.com/apache/cloudstack/pull/3898
## Description
<!--- Describe your changes in detail -->
This fixes few issues below
(1) when add/remove a vpc tier, the keepalived is restarted on both master and backup VRs, which causes some seconds donwtime of vpc.
(2) when remove a vpc tier, the password server is not stopped.
(3) vpc tier is shutdown because no vm is running for 20 minutes, if we start a vm in the vpc tier, it will be implemented. however the guest ip in VPC VRs will be changed , and password server is still running with old guest ip in VRs.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3898: vrouter: reload
keepalived instead of restart and fix password server issues when
add/remove vpc tier
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3898: vrouter: reload keepalived instead of restart and fix password server issues when add/remove vpc tier
URL: https://github.com/apache/cloudstack/pull/3898#issuecomment-592413510
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3898: vrouter:
reload keepalived instead of restart and fix password server issues when
add/remove vpc tier
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3898: vrouter: reload keepalived instead of restart and fix password server issues when add/remove vpc tier
URL: https://github.com/apache/cloudstack/pull/3898#issuecomment-592644929
<b>Trillian test result (tid-1147)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28020 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3898-t1147-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 179.66 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 175.87 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 250.59 | test_privategw_acl.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3898: vrouter:
reload keepalived instead of restart and fix password server issues when
add/remove vpc tier
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3898: vrouter: reload keepalived instead of restart and fix password server issues when add/remove vpc tier
URL: https://github.com/apache/cloudstack/pull/3898#issuecomment-592335353
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3898: vrouter: reload
keepalived instead of restart and fix password server issues when
add/remove vpc tier
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3898: vrouter: reload keepalived instead of restart and fix password server issues when add/remove vpc tier
URL: https://github.com/apache/cloudstack/pull/3898#issuecomment-592335405
@ustcweizhou can you check travis failure, see 1st job of travis -likely a python lint issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] ustcweizhou opened a new pull request #3898: vrouter:
reload keepalived instead of restart and fix password server issues when
add/remove vpc tier
Posted by GitBox <gi...@apache.org>.
ustcweizhou opened a new pull request #3898: vrouter: reload keepalived instead of restart and fix password server issues when add/remove vpc tier
URL: https://github.com/apache/cloudstack/pull/3898
## Description
<!--- Describe your changes in detail -->
This fixes few issues below
(1) when add/remove a vpc tier, the keepalived is restarted on both master and backup VRs, which causes some seconds donwtime of vpc.
(2) when remove a vpc tier, the password server is not stopped.
(3) vpc tier is shutdown because no vm is running for 20 minutes, if we start a vm in the vpc tier, it will be implemented. however the guest ip in VPC VRs will be changed , and password server is still running with old guest ip in VRs.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland merged pull request #3898: vrouter:
reload keepalived instead of restart and fix password server issues when
add/remove vpc tier
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #3898: vrouter: reload keepalived instead of restart and fix password server issues when add/remove vpc tier
URL: https://github.com/apache/cloudstack/pull/3898
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3898: vrouter:
reload keepalived instead of restart and fix password server issues when
add/remove vpc tier
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3898: vrouter: reload keepalived instead of restart and fix password server issues when add/remove vpc tier
URL: https://github.com/apache/cloudstack/pull/3898#issuecomment-592428990
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3898: vrouter: reload
keepalived instead of restart and fix password server issues when
add/remove vpc tier
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3898: vrouter: reload keepalived instead of restart and fix password server issues when add/remove vpc tier
URL: https://github.com/apache/cloudstack/pull/3898#issuecomment-588870365
@ustcweizhou can you split the PR into two as there are changes that are solely around growing partition and root disk size change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3898: vrouter: reload
keepalived instead of restart and fix password server issues when
add/remove vpc tier
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3898: vrouter: reload keepalived instead of restart and fix password server issues when add/remove vpc tier
URL: https://github.com/apache/cloudstack/pull/3898#issuecomment-592434264
@andrijapanicsb @DaanHoogland manual testing needed here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3898: vrouter:
reload keepalived instead of restart and fix password server issues when
add/remove vpc tier
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3898: vrouter: reload keepalived instead of restart and fix password server issues when add/remove vpc tier
URL: https://github.com/apache/cloudstack/pull/3898#issuecomment-592354510
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-965
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3898: vrouter:
reload keepalived instead of restart and fix password server issues when
add/remove vpc tier
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3898: vrouter: reload keepalived instead of restart and fix password server issues when add/remove vpc tier
URL: https://github.com/apache/cloudstack/pull/3898#issuecomment-588910053
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-916
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3898: vrouter:
reload keepalived instead of restart and fix password server issues when
add/remove vpc tier
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3898: vrouter: reload keepalived instead of restart and fix password server issues when add/remove vpc tier
URL: https://github.com/apache/cloudstack/pull/3898#issuecomment-588867491
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on a change in pull request #3898:
vrouter: reload keepalived instead of restart and fix password server
issues when add/remove vpc tier
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #3898: vrouter: reload keepalived instead of restart and fix password server issues when add/remove vpc tier
URL: https://github.com/apache/cloudstack/pull/3898#discussion_r381890715
##########
File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -423,6 +427,12 @@ public void allocate(final String vmInstanceName, final VirtualMachineTemplate t
final VirtualMachineProfileImpl vmProfile = new VirtualMachineProfileImpl(vmFinal, template, serviceOffering, null, null);
+ Long rootDiskSize = rootDiskOfferingInfo.getSize();
+ if (vm.getType().isUsedBySystem() && SystemVmRootDiskSize.value() != null) {
Review comment:
Perhaps the check should be of `global setting > rootDiskSize`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache closed pull request #3898: vrouter:
reload keepalived instead of restart and fix password server issues when
add/remove vpc tier
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #3898: vrouter: reload keepalived instead of restart and fix password server issues when add/remove vpc tier
URL: https://github.com/apache/cloudstack/pull/3898
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3898: vrouter: reload
keepalived instead of restart and fix password server issues when
add/remove vpc tier
Posted by GitBox <gi...@apache.org>.
ustcweizhou commented on issue #3898: vrouter: reload keepalived instead of restart and fix password server issues when add/remove vpc tier
URL: https://github.com/apache/cloudstack/pull/3898#issuecomment-588858678
@rhtyd @svenvogel @DennisKonrad
could you please test it if you use vpc ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3898: vrouter: reload
keepalived instead of restart and fix password server issues when
add/remove vpc tier
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3898: vrouter: reload keepalived instead of restart and fix password server issues when add/remove vpc tier
URL: https://github.com/apache/cloudstack/pull/3898#issuecomment-592335182
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3898: vrouter: reload
keepalived instead of restart and fix password server issues when
add/remove vpc tier
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3898: vrouter: reload keepalived instead of restart and fix password server issues when add/remove vpc tier
URL: https://github.com/apache/cloudstack/pull/3898#issuecomment-592428917
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on a change in pull request #3898:
vrouter: reload keepalived instead of restart and fix password server
issues when add/remove vpc tier
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #3898: vrouter: reload keepalived instead of restart and fix password server issues when add/remove vpc tier
URL: https://github.com/apache/cloudstack/pull/3898#discussion_r381890494
##########
File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -377,6 +377,10 @@
static final ConfigKey<Boolean> HaVmRestartHostUp = new ConfigKey<Boolean>("Advanced", Boolean.class, "ha.vm.restart.hostup", "true",
"If an out-of-band stop of a VM is detected and its host is up, then power on the VM", true);
+ static final ConfigKey<Long> SystemVmRootDiskSize = new ConfigKey<Long>("Advanced",
+ Long.class, "systemvm.root.disk.size", "-1",
Review comment:
Maybe set the default to `0`, update description to say greater than 0 has an effect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on a change in pull request #3898:
vrouter: reload keepalived instead of restart and fix password server
issues when add/remove vpc tier
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #3898: vrouter: reload keepalived instead of restart and fix password server issues when add/remove vpc tier
URL: https://github.com/apache/cloudstack/pull/3898#discussion_r381890199
##########
File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -423,6 +427,12 @@ public void allocate(final String vmInstanceName, final VirtualMachineTemplate t
final VirtualMachineProfileImpl vmProfile = new VirtualMachineProfileImpl(vmFinal, template, serviceOffering, null, null);
+ Long rootDiskSize = rootDiskOfferingInfo.getSize();
+ if (vm.getType().isUsedBySystem() && SystemVmRootDiskSize.value() != null) {
Review comment:
should there be a value/size check `> 0`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3898: vrouter: reload
keepalived instead of restart and fix password server issues when
add/remove vpc tier
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3898: vrouter: reload keepalived instead of restart and fix password server issues when add/remove vpc tier
URL: https://github.com/apache/cloudstack/pull/3898#issuecomment-589291060
need to go in teh 4.13.1 milestone , @weizhouapache ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3898: vrouter: reload
keepalived instead of restart and fix password server issues when
add/remove vpc tier
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3898: vrouter: reload keepalived instead of restart and fix password server issues when add/remove vpc tier
URL: https://github.com/apache/cloudstack/pull/3898#issuecomment-588866774
@ustcweizhou does this require a new systemvmtemplate? Can you check the 4.14 systemvmtemplate (for haproxy etc) http://download.cloudstack.org/systemvm/4.14/
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3898: vrouter:
reload keepalived instead of restart and fix password server issues when
add/remove vpc tier
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3898: vrouter: reload keepalived instead of restart and fix password server issues when add/remove vpc tier
URL: https://github.com/apache/cloudstack/pull/3898#issuecomment-588872860
@rhtyd sorry I uploaded wrong branch :-(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services