You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/04/22 18:13:56 UTC
[GitHub] [cassandra] dcapwell opened a new pull request #557: CASSANDRA-15753 bin/sstableverify should support user provided token ranges
dcapwell opened a new pull request #557:
URL: https://github.com/apache/cassandra/pull/557
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] dcapwell commented on a change in pull request #557: CASSANDRA-15753 bin/sstableverify should support user provided token ranges
Posted by GitBox <gi...@apache.org>.
dcapwell commented on a change in pull request #557:
URL: https://github.com/apache/cassandra/pull/557#discussion_r414184916
##########
File path: src/java/org/apache/cassandra/db/compaction/Verifier.java
##########
@@ -543,15 +545,17 @@ public LongPredicate getPurgeEvaluator(DecoratedKey key)
public final boolean mutateRepairStatus;
public final boolean checkOwnsTokens;
public final boolean quick;
+ public final Function<String, ? extends Collection<Range<Token>>> tokenLookup;
Review comment:
I can add some docs, but think its best to use function rather than a new interface for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic closed pull request #557: CASSANDRA-15753 bin/sstableverify should support user provided token ranges
Posted by GitBox <gi...@apache.org>.
smiklosovic closed pull request #557:
URL: https://github.com/apache/cassandra/pull/557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] dineshjoshi commented on a change in pull request #557: CASSANDRA-15753 bin/sstableverify should support user provided token ranges
Posted by GitBox <gi...@apache.org>.
dineshjoshi commented on a change in pull request #557:
URL: https://github.com/apache/cassandra/pull/557#discussion_r413501033
##########
File path: src/java/org/apache/cassandra/db/compaction/Verifier.java
##########
@@ -543,15 +545,17 @@ public LongPredicate getPurgeEvaluator(DecoratedKey key)
public final boolean mutateRepairStatus;
public final boolean checkOwnsTokens;
public final boolean quick;
+ public final Function<String, ? extends Collection<Range<Token>>> tokenLookup;
Review comment:
At the very least add a comment that documents the function. Ideally, you could just create a simple Interface/Class that can wrap this and have a meaningful method invocation like this: `Tokens.forKeyspace(String name)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] dcapwell commented on a change in pull request #557: CASSANDRA-15753 bin/sstableverify should support user provided token ranges
Posted by GitBox <gi...@apache.org>.
dcapwell commented on a change in pull request #557:
URL: https://github.com/apache/cassandra/pull/557#discussion_r414186111
##########
File path: src/java/org/apache/cassandra/db/compaction/Verifier.java
##########
@@ -543,15 +545,17 @@ public LongPredicate getPurgeEvaluator(DecoratedKey key)
public final boolean mutateRepairStatus;
public final boolean checkOwnsTokens;
public final boolean quick;
+ public final Function<String, ? extends Collection<Range<Token>>> tokenLookup;
Review comment:
added docs @dineshjoshi
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org