You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/09/14 08:07:58 UTC
[GitHub] [apisix-website] leslie-tsang opened a new pull request #596: Update customTheme.css
leslie-tsang opened a new pull request #596:
URL: https://github.com/apache/apisix-website/pull/596
Fixes: #581
Changes:
Remove width setting in customTheme.css
<!-- Add here what changes were made in this pull request and if possible provide links showcasing the changes. -->
Screenshots of the change:
https://github.com/NGX-AI/apisix-website/blob/2424e3b009788cc46b24bf97f8fb65818272278c/website/src/css/customTheme.css#L62-L65
<!-- Add screenshots depicting the changes. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan merged pull request #596: bugfix: fix APISIX architecture image size distorted
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #596:
URL: https://github.com/apache/apisix-website/pull/596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] leslie-tsang commented on a change in pull request #596: bugfix: fix APISIX architecture image size distorted
Posted by GitBox <gi...@apache.org>.
leslie-tsang commented on a change in pull request #596:
URL: https://github.com/apache/apisix-website/pull/596#discussion_r709364227
##########
File path: website/src/css/customTheme.css
##########
@@ -62,7 +62,6 @@ div.inner {
.image {
padding: 75px 10px 75px 75px;
height: 200px;
- width: 200px;
Review comment:
@liuxiran Roger that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] liuxiran commented on a change in pull request #596: bugfix: fix APISIX architecture image size distorted
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #596:
URL: https://github.com/apache/apisix-website/pull/596#discussion_r709335257
##########
File path: website/src/css/customTheme.css
##########
@@ -62,7 +62,6 @@ div.inner {
.image {
padding: 75px 10px 75px 75px;
height: 200px;
- width: 200px;
Review comment:
Hi @leslie-tsang I noticed that only remove `width` is not enough, you can try to remove `height`, just let the image adapt to the current container
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] leslie-tsang commented on pull request #596: bugfix: fix APISIX architecture image size distorted
Posted by GitBox <gi...@apache.org>.
leslie-tsang commented on pull request #596:
URL: https://github.com/apache/apisix-website/pull/596#issuecomment-919608612
@1502shivam-singh updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] liuxiran commented on pull request #596: bugfix: fix APISIX architecture image size distorted
Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #596:
URL: https://github.com/apache/apisix-website/pull/596#issuecomment-920541940
also cc @Baoyuantop to have a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] liuxiran edited a comment on pull request #596: bugfix: fix APISIX architecture image size distorted
Posted by GitBox <gi...@apache.org>.
liuxiran edited a comment on pull request #596:
URL: https://github.com/apache/apisix-website/pull/596#issuecomment-920541940
also cc @Baoyuantop to have a look, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on pull request #596: Update customTheme.css
Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on pull request #596:
URL: https://github.com/apache/apisix-website/pull/596#issuecomment-919582597
might want to update PR title to something like chore: or bug: to fix semantic pull req warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org