[GitHub] [incubator-pinot] apucher commented on pull request #6552: add optional http basic auth to pinot broker

[GitBox <gi...@apache.org>]

apucher commented on pull request #6552:
URL: https://github.com/apache/incubator-pinot/pull/6552#issuecomment-776178335


   re the first comment (which I somehow can't respond to inline):
   `.map(_principals::get)` is fine if the key, i.e. the token, is null. There's even a unit tests for this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org