You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spamassassin.apache.org by gb...@apache.org on 2022/05/16 07:46:48 UTC
svn commit: r1900942 - in /spamassassin/trunk: MANIFEST UPGRADE lib/Mail/SpamAssassin/Plugin/Esp.pm rules/v400.pre t/data/spam/esp/ t/esp.t
Author: gbechis
Date: Mon May 16 07:46:47 2022
New Revision: 1900942
URL: http://svn.apache.org/viewvc?rev=1900942&view=rev
Log:
Remove Esp plugin
Removed:
spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/Esp.pm
spamassassin/trunk/t/data/spam/esp/
spamassassin/trunk/t/esp.t
Modified:
spamassassin/trunk/MANIFEST
spamassassin/trunk/UPGRADE
spamassassin/trunk/rules/v400.pre
Modified: spamassassin/trunk/MANIFEST
URL: http://svn.apache.org/viewvc/spamassassin/trunk/MANIFEST?rev=1900942&r1=1900941&r2=1900942&view=diff
==============================================================================
--- spamassassin/trunk/MANIFEST (original)
+++ spamassassin/trunk/MANIFEST Mon May 16 07:46:47 2022
@@ -86,7 +86,6 @@ lib/Mail/SpamAssassin/Plugin/DecodeShort
lib/Mail/SpamAssassin/Plugin/DKIM.pm
lib/Mail/SpamAssassin/Plugin/DMARC.pm
lib/Mail/SpamAssassin/Plugin/DNSEval.pm
-lib/Mail/SpamAssassin/Plugin/Esp.pm
lib/Mail/SpamAssassin/Plugin/ExtractText.pm
lib/Mail/SpamAssassin/Plugin/FreeMail.pm
lib/Mail/SpamAssassin/Plugin/FromNameSpoof.pm
@@ -428,10 +427,6 @@ t/data/spam/dmarc/strictrejectko.eml
t/data/spam/dnsbl.eml
t/data/spam/dnsbl_domsonly.eml
t/data/spam/dnsbl_ipsonly.eml
-t/data/spam/esp/mailchimp.eml
-t/data/spam/esp/mailchimp.txt
-t/data/spam/esp/sendgrid_id.eml
-t/data/spam/esp/sendgrid_id.txt
t/data/spam/extracttext/gtube_jpg.eml
t/data/spam/extracttext/gtube_pdf.eml
t/data/spam/freemail1
@@ -508,7 +503,6 @@ t/dnsbl.t
t/dnsbl_sc_meta.t
t/dnsbl_subtests.t
t/enable_compat.t
-t/esp.t
t/extracttext.t
t/freemail.t
t/freemail_welcome_block.t
Modified: spamassassin/trunk/UPGRADE
URL: http://svn.apache.org/viewvc/spamassassin/trunk/UPGRADE?rev=1900942&r1=1900941&r2=1900942&view=diff
==============================================================================
--- spamassassin/trunk/UPGRADE (original)
+++ spamassassin/trunk/UPGRADE Mon May 16 07:46:47 2022
@@ -5,6 +5,8 @@ TO MAKE EDITING EASIER AND COLLABORATIVE
Note for Users Upgrading to SpamAssassin 4.0.0
----------------------------------------------
+- Esp plugin has been removed.
+
- All rules, functions, command line options and modules that contain
"whitelist" or "blacklist" have been renamed to contain more racially
neutral "welcomelist" and "blocklist" terms. Old names will continue work
Modified: spamassassin/trunk/rules/v400.pre
URL: http://svn.apache.org/viewvc/spamassassin/trunk/rules/v400.pre?rev=1900942&r1=1900941&r2=1900942&view=diff
==============================================================================
--- spamassassin/trunk/rules/v400.pre (original)
+++ spamassassin/trunk/rules/v400.pre Mon May 16 07:46:47 2022
@@ -16,10 +16,6 @@
# added to new files, named according to the release they're added in.
###########################################################################
-# Esp - Checks for spam coming from some Esp providers
-#
-# loadplugin Mail::SpamAssassin::Plugin::Esp
-
# ExtractText - Extract text from documents or images and feed it
# into SpamAssassin
#
Re: svn commit: r1900942 - in /spamassassin/trunk: MANIFEST UPGRADE lib/Mail/SpamAssassin/Plugin/Esp.pm rules/v400.pre t/data/spam/esp/ t/esp.t
Posted by Henrik K <he...@hege.li>.
As a side note and reminder for everyone, "make install" does not remove
disappeared files like Esp.pm for old users. They stay in system perl lib
directory. And as v400.pre is not overridden also, the plugin keeps
working.
Debian experimental packages might clean up old files, dunno.
On Mon, May 16, 2022 at 11:28:17AM +0300, Henrik K wrote:
>
> Do they read even the UPGRADE (I wouldn't), and actually notice what was
> added or removed? But sure, it does no harm aside from possible confusion
> for all the 3.4 people.
>
> On Mon, May 16, 2022 at 10:22:08AM +0200, giovanni@paclan.it wrote:
> > This was mostly for people updating from an old 4.0 checkout.
> > Giovanni
> >
> > On 5/16/22 10:12, Henrik K wrote:
> > >
> > > Esp.pm was never in 3.4, so kind of redundant note.
> > >
> > > On Mon, May 16, 2022 at 07:46:48AM -0000, gbechis@apache.org wrote:
> > >> Note for Users Upgrading to SpamAssassin 4.0.0
> > >> ----------------------------------------------
> > >>
> > >> +- Esp plugin has been removed.
> > >> +
> > >> - All rules, functions, command line options and modules that contain
> > >> "whitelist" or "blacklist" have been renamed to contain more racially
> > >> neutral "welcomelist" and "blocklist" terms. Old names will continue work
> >
>
>
Re: svn commit: r1900942 - in /spamassassin/trunk: MANIFEST UPGRADE lib/Mail/SpamAssassin/Plugin/Esp.pm rules/v400.pre t/data/spam/esp/ t/esp.t
Posted by Henrik K <he...@hege.li>.
Do they read even the UPGRADE (I wouldn't), and actually notice what was
added or removed? But sure, it does no harm aside from possible confusion
for all the 3.4 people.
On Mon, May 16, 2022 at 10:22:08AM +0200, giovanni@paclan.it wrote:
> This was mostly for people updating from an old 4.0 checkout.
> Giovanni
>
> On 5/16/22 10:12, Henrik K wrote:
> >
> > Esp.pm was never in 3.4, so kind of redundant note.
> >
> > On Mon, May 16, 2022 at 07:46:48AM -0000, gbechis@apache.org wrote:
> >> Note for Users Upgrading to SpamAssassin 4.0.0
> >> ----------------------------------------------
> >>
> >> +- Esp plugin has been removed.
> >> +
> >> - All rules, functions, command line options and modules that contain
> >> "whitelist" or "blacklist" have been renamed to contain more racially
> >> neutral "welcomelist" and "blocklist" terms. Old names will continue work
>
Re: svn commit: r1900942 - in /spamassassin/trunk: MANIFEST UPGRADE lib/Mail/SpamAssassin/Plugin/Esp.pm rules/v400.pre t/data/spam/esp/ t/esp.t
Posted by gi...@paclan.it.
This was mostly for people updating from an old 4.0 checkout.
Giovanni
On 5/16/22 10:12, Henrik K wrote:
>
> Esp.pm was never in 3.4, so kind of redundant note.
>
> On Mon, May 16, 2022 at 07:46:48AM -0000, gbechis@apache.org wrote:
>> Note for Users Upgrading to SpamAssassin 4.0.0
>> ----------------------------------------------
>>
>> +- Esp plugin has been removed.
>> +
>> - All rules, functions, command line options and modules that contain
>> "whitelist" or "blacklist" have been renamed to contain more racially
>> neutral "welcomelist" and "blocklist" terms. Old names will continue work
Re: svn commit: r1900942 - in /spamassassin/trunk: MANIFEST UPGRADE lib/Mail/SpamAssassin/Plugin/Esp.pm rules/v400.pre t/data/spam/esp/ t/esp.t
Posted by Henrik K <he...@hege.li>.
Esp.pm was never in 3.4, so kind of redundant note.
On Mon, May 16, 2022 at 07:46:48AM -0000, gbechis@apache.org wrote:
> Note for Users Upgrading to SpamAssassin 4.0.0
> ----------------------------------------------
>
> +- Esp plugin has been removed.
> +
> - All rules, functions, command line options and modules that contain
> "whitelist" or "blacklist" have been renamed to contain more racially
> neutral "welcomelist" and "blocklist" terms. Old names will continue work