You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@brooklyn.apache.org by ge...@apache.org on 2017/07/24 08:48:04 UTC

[1/2] brooklyn-server git commit: Reduce logging for Vault external config supplier

Repository: brooklyn-server
Updated Branches:
  refs/heads/master 34efce103 -> 04bdb7590


Reduce logging for Vault external config supplier


Project: http://git-wip-us.apache.org/repos/asf/brooklyn-server/repo
Commit: http://git-wip-us.apache.org/repos/asf/brooklyn-server/commit/6a88be55
Tree: http://git-wip-us.apache.org/repos/asf/brooklyn-server/tree/6a88be55
Diff: http://git-wip-us.apache.org/repos/asf/brooklyn-server/diff/6a88be55

Branch: refs/heads/master
Commit: 6a88be55a0eb484378507084909ea2b3ca879eac
Parents: 34efce1
Author: Valentin Aitken <bo...@gmail.com>
Authored: Sat Jul 22 16:58:04 2017 +0300
Committer: Valentin Aitken <bo...@gmail.com>
Committed: Sat Jul 22 16:58:04 2017 +0300

----------------------------------------------------------------------
 .../config/external/vault/VaultExternalConfigSupplier.java  | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/brooklyn-server/blob/6a88be55/core/src/main/java/org/apache/brooklyn/core/config/external/vault/VaultExternalConfigSupplier.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/org/apache/brooklyn/core/config/external/vault/VaultExternalConfigSupplier.java b/core/src/main/java/org/apache/brooklyn/core/config/external/vault/VaultExternalConfigSupplier.java
index f58dbc5..e642813 100644
--- a/core/src/main/java/org/apache/brooklyn/core/config/external/vault/VaultExternalConfigSupplier.java
+++ b/core/src/main/java/org/apache/brooklyn/core/config/external/vault/VaultExternalConfigSupplier.java
@@ -92,13 +92,12 @@ public abstract class VaultExternalConfigSupplier extends AbstractExternalConfig
     protected JsonObject apiGet(String path, ImmutableMap<String, String> headers) {
         try {
             String uri = Urls.mergePaths(endpoint, path);
-            LOG.debug("Vault request - GET: {}", uri);
-            LOG.debug("Vault request - headers: {}", headers.toString());
+            LOG.trace("Vault request - GET: {}", uri);
+            LOG.trace("Vault request - headers: {}", headers.toString());
             HttpToolResponse response = HttpTool.httpGet(httpClient, Urls.toUri(uri), headers);
-            LOG.debug("Vault response - code: {} {}", new Object[]{Integer.toString(response.getResponseCode()), response.getReasonPhrase()});
-            LOG.debug("Vault response - headers: {}", response.getHeaderLists().toString());
+            LOG.trace("Vault response - code: {} {}", new Object[]{Integer.toString(response.getResponseCode()), response.getReasonPhrase()});
+            LOG.trace("Vault response - headers: {}", response.getHeaderLists().toString());
             String responseBody = new String(response.getContent(), CHARSET_NAME);
-            LOG.debug("Vault response - body: {}", responseBody);
             if (HttpTool.isStatusCodeHealthy(response.getResponseCode())) {
                 return gson.fromJson(responseBody, JsonObject.class);
             } else {


[2/2] brooklyn-server git commit: Closes #774

Posted by ge...@apache.org.
Closes #774

Reduce logging for Vault external config supplier

I consider as healthier to not log `responseBody` from vault.


Project: http://git-wip-us.apache.org/repos/asf/brooklyn-server/repo
Commit: http://git-wip-us.apache.org/repos/asf/brooklyn-server/commit/04bdb759
Tree: http://git-wip-us.apache.org/repos/asf/brooklyn-server/tree/04bdb759
Diff: http://git-wip-us.apache.org/repos/asf/brooklyn-server/diff/04bdb759

Branch: refs/heads/master
Commit: 04bdb7590f79d82424dd08273b9fc6b090c4cffc
Parents: 34efce1 6a88be5
Author: Geoff Macartney <ge...@cloudsoftcorp.com>
Authored: Mon Jul 24 09:47:54 2017 +0100
Committer: Geoff Macartney <ge...@cloudsoftcorp.com>
Committed: Mon Jul 24 09:47:54 2017 +0100

----------------------------------------------------------------------
 .../config/external/vault/VaultExternalConfigSupplier.java  | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)
----------------------------------------------------------------------