[GitHub] [hadoop] liuml07 edited a comment on issue #1757: HADOOP-16757. Increase timeout unit test rule for MetadataStoreTestBase

[GitBox <gi...@apache.org>]

liuml07 edited a comment on issue #1757: HADOOP-16757. Increase timeout unit test rule for MetadataStoreTestBase
URL: https://github.com/apache/hadoop/pull/1757#issuecomment-565239454
 
 
   Since this time out is failing us by being small only sometimes, before commit, I tested more. I then found out that one point I have been missing is that: multiple rules are taking effect at the same time.
   
   So I ran that test 100 times, and some times it failed with `testAncestorOverwriteConflict...test timed out after 100000 milliseconds`. I then realized that: the base class `HadoopTestBase` has its own rule and it was *not* suppressed by the rule we newly add in this patch. So two time out rules (one in base class `HadoopTestBase` and the other newly added here), the smaller wins.
   
   So there are two ways:
   1. Make `MetadataStoreTestBase` not extend `HadoopTestBase`. I see other integration tests in fs/s3a are not extending this base class and they are using timeout defined on their own - which was what we expected.
   2. Make the rule in `HadoopTestBase` overridable in child classes, i.e. making `HadoopTestBase::retrieveTestTimeout` method non-static (and protected?). Then override it in `MetadataStoreTestBase`
   
   In new commit of this PR, I'll make use the 2nd approach since other tests may benefit from this changes, and our `MetadataStoreTestBase` could keep using other good stuff in the base class, e.g. better test name.
   
   @steveloughran Sorry I did not test enough when I filed PR, and fortunately the error showed up when I tested 100 times (not really 100, I killed it when the error happened).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org