You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/10/03 06:44:28 UTC
[GitHub] [airflow] khalidmammadov commented on a change in pull request #18685: Renaming variables to be consistent with code logic
khalidmammadov commented on a change in pull request #18685:
URL: https://github.com/apache/airflow/pull/18685#discussion_r720779366
##########
File path: airflow/api/common/experimental/trigger_dag.py
##########
@@ -77,20 +77,20 @@ def _trigger_dag(
if conf:
run_conf = conf if isinstance(conf, dict) else json.loads(conf)
- triggers = []
- dags_to_trigger = [dag] + dag.subdags
- for _dag in dags_to_trigger:
- trigger = _dag.create_dagrun(
+ dag_runs = []
+ dags_to_run = [dag] + dag.subdags
Review comment:
I agree. That should be looked at seperately. This is just a rename so it's easier to see what's happening
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org