[GitHub] [spark] pgandhi999 commented on a change in pull request #24149: [SPARK-27207] : Ensure aggregate buffers are initialized again for So…

[GitBox <gi...@apache.org>]

pgandhi999 commented on a change in pull request #24149: [SPARK-27207] : Ensure aggregate buffers are initialized again for So…
URL: https://github.com/apache/spark/pull/24149#discussion_r267844837
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/ObjectAggregationIterator.scala
 ##########
 @@ -59,17 +59,21 @@ class ObjectAggregationIterator(
   private[this] var aggBufferIterator: Iterator[AggregationBufferEntry] = _
 
   // Hacking the aggregation mode to call AggregateFunction.merge to merge two aggregation buffers
-  private val mergeAggregationBuffers: (InternalRow, InternalRow) => Unit = {
+  var (sortBasedAggExpressions, sortBasedAggFunctions): (
 
 Review comment:
   Changed it to val

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org