You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by shazron <gi...@git.apache.org> on 2016/10/11 23:23:38 UTC
[GitHub] cordova-lib pull request #500: CB-11998 - cordova platform add error with co...
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-lib/pull/500
CB-11998 - cordova platform add error with cordova-common@1.5.0
### Platforms affected
All platforms.
### What does this PR do?
Fixes "ENOENT: no such file or directory" error when adding a platform that has cordova-common@1.5.0
### What testing has been done on this change?
Added failing test in cordova-common library, then fixed it.
Added a platform with cordova-common@1.5.0 that has this fix.
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shazron/cordova-lib CB-11998
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/500.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #500
----
commit b00086fe053838580d517ed316768f5c794903dd
Author: Shazron Abdullah <sh...@apache.org>
Date: 2016-10-11T22:52:40Z
CB-11998 - cordova platform add error with cordova-common@1.5.0
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #500: CB-11998 - cordova platform add error with cordova-c...
Posted by RyanThomas73 <gi...@git.apache.org>.
Github user RyanThomas73 commented on the issue:
https://github.com/apache/cordova-lib/pull/500
One suggestion - you could simplify the source directory mapping to:
```
// Scan the files in each of the source directories.
var sourceMaps = sourceDirs.map(function (sourceDir) {
var absoluteSourceDir = path.join(rootDir, sourceDir);
if (!fs.existsSync(absoluteSourceDir)) {
throw new Error("Source directory does not exist: " + absoluteSourceDir);
}
return mapDirectory(rootDir, sourceDir, include, exclude);
});
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #500: CB-11998 - cordova platform add error with cordova-c...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-lib/pull/500
@RyanThomas73 thanks! Unfortunately I've already spent too much time on this one line fix, so I'm probably not going to re-visit it for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #500: CB-11998 - cordova platform add error with co...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/500
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org