You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/17 07:09:58 UTC
[GitHub] [pulsar] tjiuming opened a new pull request, #16108: [fix][broker][monitoring] fix message ack rate
tjiuming opened a new pull request, #16108:
URL: https://github.com/apache/pulsar/pull/16108
### Motivation
fix [PR.15674](https://github.com/apache/pulsar/pull/15674), there was a incorrect API usage in it, need to fix.
### Modifications
fix issue
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #16108: [fix][broker][monitoring] fix message ack rate
Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #16108:
URL: https://github.com/apache/pulsar/pull/16108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tjiuming commented on pull request #16108: [fix][broker][monitoring] fix message ack rate
Posted by GitBox <gi...@apache.org>.
tjiuming commented on PR #16108:
URL: https://github.com/apache/pulsar/pull/16108#issuecomment-1161296340
@codelipenghui Fixed batch messages ack rate, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tjiuming commented on pull request #16108: [fix][broker][monitoring] fix message ack rate
Posted by GitBox <gi...@apache.org>.
tjiuming commented on PR #16108:
URL: https://github.com/apache/pulsar/pull/16108#issuecomment-1158565525
@codelipenghui PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #16108: [fix][broker][monitoring] fix message ack rate
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on PR #16108:
URL: https://github.com/apache/pulsar/pull/16108#issuecomment-1160342368
@tjiuming Please check the failed test
```
Error: Tests run: 15, Failures: 1, Errors: 0, Skipped: 11, Time elapsed: 35.275 s <<< FAILURE! - in org.apache.pulsar.broker.stats.ConsumerStatsTest
Error: testPersistentTopicMessageAckRateMetricNamespaceLevel(org.apache.pulsar.broker.stats.ConsumerStatsTest) Time elapsed: 1.558 s <<< FAILURE!
java.lang.AssertionError: expected [2] but found [0]
at org.testng.Assert.fail(Assert.java:99)
at org.testng.Assert.failNotEquals(Assert.java:1037)
at org.testng.Assert.assertEqualsImpl(Assert.java:140)
at org.testng.Assert.assertEquals(Assert.java:122)
at org.testng.Assert.assertEquals(Assert.java:907)
at org.testng.Assert.assertEquals(Assert.java:917)
at org.apache.pulsar.broker.stats.ConsumerStatsTest.testMessageAckRateMetric(ConsumerStatsTest.java:299)
at org.apache.pulsar.broker.stats.ConsumerStatsTest.testPersistentTopicMessageAckRateMetricNamespaceLevel(ConsumerStatsTest.java:248)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132)
at org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:45)
at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:73)
at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:11)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:833)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org