You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/14 07:34:46 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #39060: [SPARK-41506][CONNECT][PYTHON][FOLLOWUP] Support typed null
zhengruifeng opened a new pull request, #39060:
URL: https://github.com/apache/spark/pull/39060
### What changes were proposed in this pull request?
https://github.com/apache/spark/pull/39047 forgot to deal with typed_null in the server side,
this PR fix it and add e2e tests for each supported types
### Why are the changes needed?
to make sure typed null works
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
added tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #39060: [SPARK-41506][CONNECT][PYTHON][FOLLOWUP] Support typed null
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on code in PR #39060:
URL: https://github.com/apache/spark/pull/39060#discussion_r1048106561
##########
python/pyspark/sql/tests/connect/test_connect_column.py:
##########
@@ -202,6 +203,9 @@ def test_literal_null(self):
self.assertTrue(lit_null._value is None)
self.assertEqual(dataType, lit_null._dataType)
+ cdf = self.connect.range(0, 1).select(Column(lit_null))
Review Comment:
for each datatype supported in `LiteralExpression`, create a df containing the literal column and check the schema
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #39060: [SPARK-41506][CONNECT][PYTHON][FOLLOWUP] Support typed null
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #39060:
URL: https://github.com/apache/spark/pull/39060#issuecomment-1350604434
also cc @dengziming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #39060: [SPARK-41506][CONNECT][PYTHON][FOLLOWUP] Support typed null
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on code in PR #39060:
URL: https://github.com/apache/spark/pull/39060#discussion_r1048106561
##########
python/pyspark/sql/tests/connect/test_connect_column.py:
##########
@@ -202,6 +203,9 @@ def test_literal_null(self):
self.assertTrue(lit_null._value is None)
self.assertEqual(dataType, lit_null._dataType)
+ cdf = self.connect.range(0, 1).select(Column(lit_null))
Review Comment:
for each datatype supported in `LiteralExpression`, create a df containing the literal column and then check the schema
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #39060: [SPARK-41506][CONNECT][PYTHON][FOLLOWUP] Support typed null
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #39060:
URL: https://github.com/apache/spark/pull/39060#issuecomment-1350548960
@amaliujia @cloud-fan @HyukjinKwon @grundprinzip
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #39060: [SPARK-41506][CONNECT][PYTHON][FOLLOWUP] Support typed null
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #39060: [SPARK-41506][CONNECT][PYTHON][FOLLOWUP] Support typed null
URL: https://github.com/apache/spark/pull/39060
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #39060: [SPARK-41506][CONNECT][PYTHON][FOLLOWUP] Support typed null
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #39060:
URL: https://github.com/apache/spark/pull/39060#issuecomment-1352384703
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org