You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Cenk Uyan (Code Review)" <ge...@cloudera.org> on 2016/06/08 13:31:15 UTC
[kudu-CR] Update documentation and build helper script
Cenk Uyan has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3336
Change subject: Update documentation and build helper script
......................................................................
Update documentation and build helper script
Added 'unzip' pkg among dependencies for building kudu from source
on Centos 6.6 .
Removed dependency on `lsb_release` command required by
enable_devtoolset.sh (which requires redhat-lsb-core RPM package).
Change-Id: I4873e2965659241f7131a49701a06ac423d30f96
---
M build-support/enable_devtoolset.sh
M docs/installation.adoc
2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/3336/1
--
To view, visit http://gerrit.cloudera.org:8080/3336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4873e2965659241f7131a49701a06ac423d30f96
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Cenk Uyan <ce...@gmail.com>
[kudu-CR] Update documentation and build helper script
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Update documentation and build helper script
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/1781/
--
To view, visit http://gerrit.cloudera.org:8080/3336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4873e2965659241f7131a49701a06ac423d30f96
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Cenk Uyan <ce...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] Update documentation and build helper script
Posted by "Cenk Uyan (Code Review)" <ge...@cloudera.org>.
Cenk Uyan has abandoned this change.
Change subject: Update documentation and build helper script
......................................................................
Abandoned
will resubmit
--
To view, visit http://gerrit.cloudera.org:8080/3336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I4873e2965659241f7131a49701a06ac423d30f96
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Cenk Uyan <ce...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Update documentation and build helper script
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: Update documentation and build helper script
......................................................................
Patch Set 1:
(1 comment)
In order to pass validation, this patch will need to be rebased over the latest changes in the master branch. We unfortunately had a breaking change to the testing infrastructure, and the fix only went in yesterday.
http://gerrit.cloudera.org:8080/#/c/3336/1/build-support/enable_devtoolset.sh
File build-support/enable_devtoolset.sh:
Line 28: [[ "$(cat /etc/redhat-release)" =~ (CentOS|RedHatEnterpriseServer)([[:space:]]|[[:alnum:]])*[[:space:]]+6\.[[:digit:]]+ ]]; then
This will fail on non-RHEL derived distros (notice the `set -e` above). Is it possible to instead add the provider of `lsb_release` as an RPM dependency?
--
To view, visit http://gerrit.cloudera.org:8080/3336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4873e2965659241f7131a49701a06ac423d30f96
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Cenk Uyan <ce...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes