You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2011/05/18 15:20:09 UTC
[Bug 6592] New: 3.3.2rc1 fails t/spamd_sql_prefs.t tests 14
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6592
Bug #: 6592
Summary: 3.3.2rc1 fails t/spamd_sql_prefs.t tests 14
Product: Spamassassin
Version: 3.3.1
Platform: All
OS/Version: All
Status: NEW
Severity: blocker
Priority: P2
Component: Regression Tests
AssignedTo: dev@spamassassin.apache.org
ReportedBy: sidney@sidney.com
Classification: Unclassified
Created attachment 4893
--> https://issues.apache.org/SpamAssassin/attachment.cgi?id=4893
log TEST_VERBOSE=1 output of the test
I am only seeing this failure in builds from the 3.3.2rc1 tarball.
I do not get these failures in svn trunk or in svn branches/3.3
I do get these failures identically on a Macbook running Mac OS 10.6.7 32-bit
with perl 5.12.3, and on a box running Fedora 14 64-bit also with perl 5.12.3.
I also tested the Macbook on the same network as the Fedora machine and on a
completely different one to eliminate the possibility of the local
network/firewall/etc. setup being a factor.
I am attaching the result of
make test TEST_FILES=t/spamd_sql_prefs.t TEST_VERBOSE=1 &> ~/tmp/bug332sql.log
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6592] 3.3.2rc1 fails t/spamd_sql_prefs.t tests 14
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6592
Sidney Markowitz <si...@sidney.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |sidney@sidney.com
Version|3.3.1 |3.3.2
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6592] 3.3.2rc1 fails t/spamd_sql_prefs.t tests 14
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6592
--- Comment #1 from Mark Martinec <Ma...@ijs.si> 2011-05-18 14:24:06 UTC ---
Same issue as Bug 6591 and Bug 6500#c12 : no rules in the kit.
No rules to recognize a GTUBE pattern, consequently a test
message is not considered spam and lacks an X-Spam-Flag: YES
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6592] [review] 3.3.2rc1 fails t/spamd_sql_prefs.t tests 14
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6592
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #8 from Kevin A. McGrail <km...@pccc.com> 2011-05-28 09:37:59 UTC ---
Trunk revision 1124333 applied to 3.3 branch.
Passes all tests with long/net/run_sql_pref_tests=y, woohoo!
Sending t/data/spam/018
Sending t/spamd_sql_prefs.t
Transmitting file data ..
Committed revision 1128579.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6592] 3.3.2rc1 fails t/spamd_sql_prefs.t tests 14
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6592
--- Comment #5 from Mark Martinec <Ma...@ijs.si> 2011-05-18 16:33:11 UTC ---
trunk:
Bug 6592: 3.3.2rc1 fails t/spamd_sql_prefs.t tests 14
Sending t/data/spam/018
Sending t/spamd_sql_prefs.t
Committed revision 1124333.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6592] [review] 3.3.2rc1 fails t/spamd_sql_prefs.t tests 14
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6592
Henrik Krohns <he...@hege.li> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 1 votes for 3.3.2 |ready to commit for 3.3.2
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6592] 3.3.2rc1 fails t/spamd_sql_prefs.t tests 14
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6592
--- Comment #2 from Mark Martinec <Ma...@ijs.si> 2011-05-18 15:45:32 UTC ---
> No rules to recognize a GTUBE pattern, consequently a test
> message is not considered spam and lacks an X-Spam-Flag: YES
Actually it must be something else,
the GTUBE rule is in the t/data/01_test_rules.cf
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6592] [review] 3.3.2rc1 fails t/spamd_sql_prefs.t tests 14
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6592
Henrik Krohns <he...@hege.li> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hege@hege.li
--- Comment #7 from Henrik Krohns <he...@hege.li> 2011-05-25 07:39:46 UTC ---
(In reply to comment #6)
> (In reply to comment #5)
> > trunk:
> > Bug 6592: 3.3.2rc1 fails t/spamd_sql_prefs.t tests 14
> > Sending t/data/spam/018
> > Sending t/spamd_sql_prefs.t
> > Committed revision 1124333.
>
> +1 for 3.3.
+1 also
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6592] 3.3.2rc1 fails t/spamd_sql_prefs.t tests 14
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6592
--- Comment #3 from Mark Martinec <Ma...@ijs.si> 2011-05-18 16:29:39 UTC ---
The failing test #14 is just plain wrong I believe.
It takes t/data/spam/018 as a data source, which is spammy mainly
because it contains a GTUBE test pattern. So when a GTUBE rule
has a default score of 1000 the message is clearly detected as
spam, which is correctly detected by a test.
Now the test #14 switches user prefs to 'score GTUBE 0',
which turns off the main reason why the t/data/spam/018 can
be considered spam. The test #14 nevertheless still insists
that the result should be tagged as 'X-Spam-Flag: YES',
but it has no good reason to expect so.
As it happens, because of other tests like INVALID_DATE, the
message still barely exceeds the spam threshold in trunk and
in the 3.3 svn branch (which both carry additional rules) and
the test #14 passes, but does not reach a threshold in the
distributed package, which has no other rules besides test rules.
Suggested solution:
- move the 'X-Spam-Flag: YES' from %patterns into %anti_patterns
- fix Date header field in the mail sample t/data/spam/018 so
that it does not trigger INVALID_DATE
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6592] [review] 3.3.2rc1 fails t/spamd_sql_prefs.t tests 14
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6592
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|3.3.2rc1 fails |[review] 3.3.2rc1 fails
|t/spamd_sql_prefs.t tests |t/spamd_sql_prefs.t tests
|14 |14
Status Whiteboard| |needs 2 votes for 3.3.2
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6592] 3.3.2rc1 fails t/spamd_sql_prefs.t tests 14
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6592
Mark Martinec <Ma...@ijs.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |3.3.2
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6592] 3.3.2rc1 fails t/spamd_sql_prefs.t tests 14
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6592
--- Comment #4 from Mark Martinec <Ma...@ijs.si> 2011-05-18 16:30:55 UTC ---
Created attachment 4894
--> https://issues.apache.org/SpamAssassin/attachment.cgi?id=4894
fixes test t/spamd_sql_prefs.t and t/data/spam/018
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6592] [review] 3.3.2rc1 fails t/spamd_sql_prefs.t tests 14
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6592
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kmcgrail@pccc.com
Status Whiteboard|needs 2 votes for 3.3.2 |needs 1 votes for 3.3.2
--- Comment #6 from Kevin A. McGrail <km...@pccc.com> 2011-05-24 16:02:24 UTC ---
(In reply to comment #5)
> trunk:
> Bug 6592: 3.3.2rc1 fails t/spamd_sql_prefs.t tests 14
> Sending t/data/spam/018
> Sending t/spamd_sql_prefs.t
> Committed revision 1124333.
+1 for 3.3.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.