You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/03/06 00:57:14 UTC
Review Request 70134: Fixed
`PartitionTest.PartitionAwareTaskCompletedOnPartitionedAgent`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70134/
-----------------------------------------------------------
Review request for mesos and Meng Zhu.
Bugs: MESOS-9089
https://issues.apache.org/jira/browse/MESOS-9089
Repository: mesos
Description
-------
The test flake is fixed by adding proper synchronizations to ensure that
the agent's task status update manager has received task status updates
before moving on.
Diffs
-----
src/tests/partition_tests.cpp 6cdfe97360c6e2a91b71f03efb0c29998e2d4b9f
Diff: https://reviews.apache.org/r/70134/diff/1/
Testing
-------
`make check`
Run the test in repetition.
Thanks,
Chun-Hung Hsiao
Re: Review Request 70134: Fixed
`PartitionTest.PartitionAwareTaskCompletedOnPartitionedAgent`.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70134/#review213451
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On March 5, 2019, 4:57 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70134/
> -----------------------------------------------------------
>
> (Updated March 5, 2019, 4:57 p.m.)
>
>
> Review request for mesos and Meng Zhu.
>
>
> Bugs: MESOS-9089
> https://issues.apache.org/jira/browse/MESOS-9089
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test flake is fixed by adding proper synchronizations to ensure that
> the agent's task status update manager has received task status updates
> before moving on.
>
>
> Diffs
> -----
>
> src/tests/partition_tests.cpp 6cdfe97360c6e2a91b71f03efb0c29998e2d4b9f
>
>
> Diff: https://reviews.apache.org/r/70134/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
> Run the test in repetition.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 70134: Fixed
`PartitionTest.PartitionAwareTaskCompletedOnPartitionedAgent`.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70134/#review213456
-----------------------------------------------------------
Ship it!
Ship It!
- Meng Zhu
On March 5, 2019, 4:57 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70134/
> -----------------------------------------------------------
>
> (Updated March 5, 2019, 4:57 p.m.)
>
>
> Review request for mesos and Meng Zhu.
>
>
> Bugs: MESOS-9089
> https://issues.apache.org/jira/browse/MESOS-9089
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test flake is fixed by adding proper synchronizations to ensure that
> the agent's task status update manager has received task status updates
> before moving on.
>
>
> Diffs
> -----
>
> src/tests/partition_tests.cpp 6cdfe97360c6e2a91b71f03efb0c29998e2d4b9f
>
>
> Diff: https://reviews.apache.org/r/70134/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
> Run the test in repetition.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>