You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "vtlim (via GitHub)" <gi...@apache.org> on 2023/05/02 23:48:55 UTC

[GitHub] [druid] vtlim commented on a diff in pull request #14197: update documentation about multiValueHandling

vtlim commented on code in PR #14197:
URL: https://github.com/apache/druid/pull/14197#discussion_r1183140738


##########
docs/ingestion/ingestion-spec.md:
##########
@@ -226,7 +226,7 @@ Dimension objects can have the following components:
 | type | Either `string`, `long`, `float`, `double`, or `json`. | `string` |
 | name | The name of the dimension. This will be used as the field name to read from input records, as well as the column name stored in generated segments.<br /><br />Note that you can use a [`transformSpec`](#transformspec) if you want to rename columns during ingestion time. | none (required) |
 | createBitmapIndex | For `string` typed dimensions, whether or not bitmap indexes should be created for the column in generated segments. Creating a bitmap index requires more storage, but speeds up certain kinds of filtering (especially equality and prefix filtering). Only supported for `string` typed dimensions. | `true` |
-| multiValueHandling | Specify the type of handling for [multi-value fields](../querying/multi-value-dimensions.md). Possible values are `sorted_array`, `sorted_set`, and `array`. `sorted_array` and `sorted_set` order the array upon ingestion. `sorted_set` removes duplicates. `array` ingests data as-is | `sorted_array` |
+| multiValueHandling | Specify the type of handling for [multi-value fields](../querying/multi-value-dimensions.md). Possible values are `sorted_array`, `sorted_set`, and `array`. `sorted_array` and `sorted_set` order the array upon ingestion. For `string` typed dimensions, `sorted_set` removes duplicates. For `string` typed dimensions, `array` ingests data as-is. | `sorted_array` |

Review Comment:
   ```suggestion
   | multiValueHandling | Specify the type of handling for [multi-value fields](../querying/multi-value-dimensions.md). Possible values are `sorted_array`, `sorted_set`, and `array`. Both `sorted_array` and `sorted_set` order the array upon ingestion. For string typed dimensions, `sorted_set` removes duplicates. For string typed dimensions, `array` ingests data as is. | `sorted_array` |
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org