You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/01 01:21:59 UTC

[GitHub] [spark] HyukjinKwon edited a comment on pull request #33875: [SPARK-36608][SQL] Support TimestampNTZ in Arrow

HyukjinKwon edited a comment on pull request #33875:
URL: https://github.com/apache/spark/pull/33875#issuecomment-909784623


   > So is this to support time-zone naive timestamps as described in  https://github.com/apache/arrow/blob/master/format/Schema.fbs#L255 ?
   
   Yes, I double checked the semantic, and I think there isn't any hole in the current implementation.
   
   >  I'm trying to remember way back when we first did timestamps and I thought we needed to always conform to time zone in "spark.sql.session.timeZone" which defaults to the local time zone?
   
   Yes. This specific `TimestampNTZType` is an exception (to comply ANSI standard). In Spark code side, it computes with UTC as well so I think we're all good.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org