[GitHub] [superset] kgabryje commented on a change in pull request #19071: fix: Pivot Table Conditional Formatting Doesn't Show All Options

[GitBox <gi...@apache.org>]

kgabryje commented on a change in pull request #19071:
URL: https://github.com/apache/superset/pull/19071#discussion_r822841418



##########
File path: superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
##########
@@ -108,6 +108,9 @@ const all_columns: typeof sharedControls.groupby = {
   optionRenderer: c => <ColumnOption showType column={c} />,
   valueRenderer: c => <ColumnOption column={c} />,
   valueKey: 'column_name',
+  shouldMapStateToProps() {

Review comment:
       Do we need it here and in other controls in Table? `mapStateToProps` has only 2 arguments, so we do not need to run it every time




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org