You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/20 15:00:16 UTC
[GitHub] [maven] nielsbasjes opened a new pull request, #838: Fix project versions not updated during release
nielsbasjes opened a new pull request, #838:
URL: https://github.com/apache/maven/pull/838
For an unknown reason the versions in the various modules were not updated correctly during the previous new snapshot version.
This only fixes the current versions. It does not address the root cause at this point.
----
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] nielsbasjes commented on a diff in pull request #838: Fix project versions not updated during release
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on code in PR #838:
URL: https://github.com/apache/maven/pull/838#discussion_r1001170291
##########
maven-model/src/test/resources/xml/pom.xml:
##########
@@ -25,7 +25,7 @@ under the License.
<parent>
<groupId>org.apache.maven</groupId>
<artifactId>maven</artifactId>
- <version>4.0.0-alpha-1-SNAPSHOT</version>
+ <version>4.0.0-alpha-3-SNAPSHOT</version>
Review Comment:
Resource filtering works.
Even though the version is `dummy-version` the places where it says `${project.version}` now actually becomes the actual version of the project for testing purposes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] nielsbasjes commented on a diff in pull request #838: Fix project versions not updated during release
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on code in PR #838:
URL: https://github.com/apache/maven/pull/838#discussion_r1001161125
##########
maven-model/src/test/resources/xml/pom.xml:
##########
@@ -25,7 +25,7 @@ under the License.
<parent>
<groupId>org.apache.maven</groupId>
<artifactId>maven</artifactId>
- <version>4.0.0-alpha-1-SNAPSHOT</version>
+ <version>4.0.0-alpha-3-SNAPSHOT</version>
Review Comment:
Yes.
The tricky part here is that in this file all versions were missed.
I'll have to check if something as resource filtering can handle this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #838: Fix project versions not updated during release
Posted by GitBox <gi...@apache.org>.
gnodet commented on PR #838:
URL: https://github.com/apache/maven/pull/838#issuecomment-1286160985
It's not only that, the `versions:set` goal did not update it during the release either:
https://github.com/apache/maven/blob/maven-4.0.0-alpha-2/maven-model/pom.xml#L64-L71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] nielsbasjes commented on a diff in pull request #838: Fix project versions not updated during release
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on code in PR #838:
URL: https://github.com/apache/maven/pull/838#discussion_r1001600141
##########
maven-model/pom.xml:
##########
@@ -37,16 +37,22 @@ under the License.
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-api-model</artifactId>
- <version>4.0.0-alpha-3-SNAPSHOT</version>
+ <version>${project.version}</version>
Review Comment:
Will do. I'll get on it this weekend .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] nielsbasjes commented on a diff in pull request #838: Fix project versions not updated during release
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on code in PR #838:
URL: https://github.com/apache/maven/pull/838#discussion_r1001158468
##########
maven-model/pom.xml:
##########
@@ -64,7 +64,7 @@ under the License.
<artifactItem>
<groupId>org.apache.maven</groupId>
<artifactId>maven-api-model</artifactId>
- <version>4.0.0-alpha-1-SNAPSHOT</version>
+ <version>4.0.0-alpha-3-SNAPSHOT</version>
Review Comment:
How about I change it everywhere where possible to `${project.version}`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #838: Fix project versions not updated during release
Posted by GitBox <gi...@apache.org>.
gnodet commented on PR #838:
URL: https://github.com/apache/maven/pull/838#issuecomment-1286963027
@nielsbasjes do you mind if I do the changes locally, that's really a nasty problem and should be fixed asap imho.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on a diff in pull request #838: Fix project versions not updated during release
Posted by GitBox <gi...@apache.org>.
gnodet commented on code in PR #838:
URL: https://github.com/apache/maven/pull/838#discussion_r1001585461
##########
maven-model/src/test/resources/xml/pom.xml:
##########
@@ -37,12 +37,12 @@ under the License.
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-api-model</artifactId>
- <version>4.0.0-alpha-1-SNAPSHOT</version>
+ <version>${project.version}</version>
Review Comment:
I'd rather have all the versions in this file set to `dummy-version` with no filtering... see comment above.
##########
maven-model/pom.xml:
##########
@@ -37,16 +37,22 @@ under the License.
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-api-model</artifactId>
- <version>4.0.0-alpha-3-SNAPSHOT</version>
+ <version>${project.version}</version>
Review Comment:
Actually, this should be better added to dependency management of the parent pom along with all other modules defined in the build.
##########
maven-settings/pom.xml:
##########
@@ -37,12 +37,12 @@ under the License.
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-api-settings</artifactId>
- <version>4.0.0-alpha-3-SNAPSHOT</version>
+ <version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-xml-impl</artifactId>
- <version>4.0.0-alpha-3-SNAPSHOT</version>
+ <version>${project.version}</version>
Review Comment:
Dependency management...
##########
maven-settings/pom.xml:
##########
@@ -37,12 +37,12 @@ under the License.
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-api-settings</artifactId>
- <version>4.0.0-alpha-3-SNAPSHOT</version>
+ <version>${project.version}</version>
Review Comment:
Dependency management...
##########
maven-model/pom.xml:
##########
@@ -37,16 +37,22 @@ under the License.
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-api-model</artifactId>
- <version>4.0.0-alpha-3-SNAPSHOT</version>
+ <version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-xml-impl</artifactId>
- <version>4.0.0-alpha-3-SNAPSHOT</version>
+ <version>${project.version}</version>
Review Comment:
Dependency management...
##########
maven-model/pom.xml:
##########
@@ -37,16 +37,22 @@ under the License.
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-api-model</artifactId>
- <version>4.0.0-alpha-3-SNAPSHOT</version>
+ <version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-xml-impl</artifactId>
- <version>4.0.0-alpha-3-SNAPSHOT</version>
+ <version>${project.version}</version>
</dependency>
</dependencies>
<build>
+ <testResources>
+ <testResource>
+ <directory>src/test/resources</directory>
+ <filtering>true</filtering>
+ </testResource>
+ </testResources>
Review Comment:
There's no real need for filtering resources here. The exact content of the `xml/pom.xml` is really not important, the test just needs a model with a few things in it, but the values are not used.
##########
maven-toolchain-model/pom.xml:
##########
@@ -36,12 +36,12 @@ under the License.
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-api-toolchain</artifactId>
- <version>4.0.0-alpha-3-SNAPSHOT</version>
+ <version>${project.version}</version>
Review Comment:
Dependency management...
##########
maven-toolchain-model/pom.xml:
##########
@@ -36,12 +36,12 @@ under the License.
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-api-toolchain</artifactId>
- <version>4.0.0-alpha-3-SNAPSHOT</version>
+ <version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-xml-impl</artifactId>
- <version>4.0.0-alpha-3-SNAPSHOT</version>
+ <version>${project.version}</version>
Review Comment:
Dependency management...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on a diff in pull request #838: Fix project versions not updated during release
Posted by GitBox <gi...@apache.org>.
gnodet commented on code in PR #838:
URL: https://github.com/apache/maven/pull/838#discussion_r1001138925
##########
maven-model/pom.xml:
##########
@@ -64,7 +64,7 @@ under the License.
<artifactItem>
<groupId>org.apache.maven</groupId>
<artifactId>maven-api-model</artifactId>
- <version>4.0.0-alpha-1-SNAPSHOT</version>
+ <version>4.0.0-alpha-3-SNAPSHOT</version>
Review Comment:
Given the version is not changed during the release, this will break again. Would you mind changing to `${project.version}` instead ?
##########
maven-model/src/test/resources/xml/pom.xml:
##########
@@ -25,7 +25,7 @@ under the License.
<parent>
<groupId>org.apache.maven</groupId>
<artifactId>maven</artifactId>
- <version>4.0.0-alpha-1-SNAPSHOT</version>
+ <version>4.0.0-alpha-3-SNAPSHOT</version>
Review Comment:
This file is a test pom which is simply loaded, the version number is not important. For clarity, if we really want to change it, maybe use something like `dummy-version` instead of something that can be misinterpreted as a real version.
##########
maven-settings/pom.xml:
##########
@@ -68,7 +68,7 @@ under the License.
<artifactItem>
<groupId>org.apache.maven</groupId>
<artifactId>maven-api-settings</artifactId>
- <version>4.0.0-alpha-1-SNAPSHOT</version>
+ <version>4.0.0-alpha-3-SNAPSHOT</version>
Review Comment:
Use `${project.version}`.
##########
maven-toolchain-model/pom.xml:
##########
@@ -67,7 +67,7 @@ under the License.
<artifactItem>
<groupId>org.apache.maven</groupId>
<artifactId>maven-api-toolchain</artifactId>
- <version>4.0.0-alpha-1-SNAPSHOT</version>
+ <version>4.0.0-alpha-3-SNAPSHOT</version>
Review Comment:
Use `${project.version}`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #838: Fix project versions not updated during release
Posted by GitBox <gi...@apache.org>.
gnodet commented on PR #838:
URL: https://github.com/apache/maven/pull/838#issuecomment-1287136310
Fixed by https://github.com/apache/maven/commit/0d70f7295de75fcd00d69789a19d2866348f97bb for the most important part. A cleanup using the BOM / dependency management needs to follow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet closed pull request #838: Fix project versions not updated during release
Posted by GitBox <gi...@apache.org>.
gnodet closed pull request #838: Fix project versions not updated during release
URL: https://github.com/apache/maven/pull/838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] nielsbasjes commented on a diff in pull request #838: Fix project versions not updated during release
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on code in PR #838:
URL: https://github.com/apache/maven/pull/838#discussion_r1001169223
##########
maven-model/pom.xml:
##########
@@ -64,7 +64,7 @@ under the License.
<artifactItem>
<groupId>org.apache.maven</groupId>
<artifactId>maven-api-model</artifactId>
- <version>4.0.0-alpha-1-SNAPSHOT</version>
+ <version>4.0.0-alpha-3-SNAPSHOT</version>
Review Comment:
I've set it to ${project.version} in all files I touched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] nielsbasjes commented on pull request #838: Fix project versions not updated during release
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on PR #838:
URL: https://github.com/apache/maven/pull/838#issuecomment-1287022003
Sure, go for it and I'll close this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org