[GitHub] mxm commented on issue #7249: [FLINK-11048] Ability to programmatically execute streaming pipeline with savepoint restore

[GitBox <gi...@apache.org>]

mxm commented on issue #7249: [FLINK-11048] Ability to programmatically execute streaming pipeline with savepoint restore
URL: https://github.com/apache/flink/pull/7249#issuecomment-447805145
 
 
   >I think the constructor proliferation suffers from its own issues: besides repetition you need to decide how to prioritize parameters that naturally have no priority.
   
   That's the nature of fixed method parameters. I agree that "`ExecutionParameters`" would be nicer, essentially just a map of config parameters with no order imposed.
   
   > How about passing the savepoint parameter or before mentioned new parameters holder through a thread local instead of the instance variable? The difference how we pass it internally is cosmetic and not important to the user. The question of savepoint vs. generalized execution parameters seems more interesting.
   
   I don't think that would change much. Granted, other threads wouldn't be able to see the savepoint options, but I think that would make the behavior even more unexpected.
   
   Until this is refactored, IMHO it is ok to add another constructor parameter or another parameter to the execute method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services