You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/31 16:57:04 UTC
[jira] [Commented] (IGNITE-5364) Remove contention on DataStructure
creation or removing
[ https://issues.apache.org/jira/browse/IGNITE-5364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16031511#comment-16031511 ]
ASF GitHub Bot commented on IGNITE-5364:
----------------------------------------
GitHub user mcherkasov opened a pull request:
https://github.com/apache/ignite/pull/2053
IGNITE-5364 Remove contention on DataStructure creation or removing
All DSs are stored in one Map which itself is stored in utilityCache, this makes high contention on DS creation or removing, it requires lock on the key and manipulation with the Map under the lock. So all threads in cluster should wait for this lock to create or remove DS.
I don't see any reason to store all DS in one map, we already have utilityCache and can save DSs directly in utilityCache, to distinguish DS with other objects in utilityCache I use composite key, the first part of which is DATA_STRUCTURES_KEY, second one is DS's name, also DS type can be added, this will allow us to create different DS with the same name.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-5364
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/2053.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2053
----
commit 1d2c6b9c97584cf7603aa08ee07e71940037f92f
Author: mcherkasov <mc...@gridgain.com>
Date: 2017-05-31T16:17:52Z
Removed a Map with DataStructures. DataStructures are added directly to utilityCache.
----
> Remove contention on DataStructure creation or removing
> -------------------------------------------------------
>
> Key: IGNITE-5364
> URL: https://issues.apache.org/jira/browse/IGNITE-5364
> Project: Ignite
> Issue Type: Improvement
> Reporter: Mikhail Cherkasov
> Assignee: Mikhail Cherkasov
> Fix For: 2.1
>
>
> All DSs are stored in one Map which itself is stored in utilityCache, this makes high contention on DS creation or removing, it requires lock on the key and manipulation with the Map under the lock. So all threads in cluster should wait for this lock to create or remove DS.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)