[GitHub] [bookkeeper] codelipenghui commented on a change in pull request #2757: change log level from error to warn in getReadLacResponse

[GitBox <gi...@apache.org>]

codelipenghui commented on a change in pull request #2757:
URL: https://github.com/apache/bookkeeper/pull/2757#discussion_r681398354



##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadLacProcessorV3.java
##########
@@ -89,10 +89,10 @@ private ReadLacResponse getReadLacResponse() {
             }
         } catch (Bookie.NoLedgerException e) {
             status = StatusCode.ENOLEDGER;
-            logger.error("No ledger found while trying to read last entry: {}", ledgerId, e);
+            logger.warn("No ledger found while trying to read last entry: {}", ledgerId, e);
         } catch (IOException e) {
             status = StatusCode.EIO;
-            logger.error("IOException while trying to read last entry: {}", ledgerId, e);
+            logger.warn("IOException while trying to read last entry: {}", ledgerId, e);

Review comment:
       We should only change the logger level to WARN for `NoEntryException` not all  IOException. The purpose of this PR should be if users provided a wrong ledger ID or an entry ID, the log level should be WARN.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org