You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by iilyak <gi...@git.apache.org> on 2016/07/11 19:24:20 UTC

[GitHub] couchdb-fabric pull request #62: Use the correct sequence for shard replacem...

GitHub user iilyak opened a pull request:

    https://github.com/apache/couchdb-fabric/pull/62

    Use the correct sequence for shard replacement

    Cherry-pick from Cloudant to 2.0
    
    The call to unpack the since sequence for _changes incorrectly filtered
    the value for any shard that didn't exist. This means that any shard
    that was moved ended up requiring a complete rescan which is a bug. This
    just sets the update sequence to the range of the shard being replaced
    rather than zero.
    
    COUCHDB-3055

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloudant/couchdb-fabric 44287-use-correct-sequence-for-shard-replacement

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-fabric/pull/62.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #62
    
----
commit 5d0995966c117e3cf946216aff41116c2020c212
Author: Paul J. Davis <pa...@gmail.com>
Date:   2015-02-11T03:49:40Z

    Use the correct sequence for shard replacement
    
    The call to unpack the since sequence for _changes incorrectly filtered
    the value for any shard that didn't exist. This means that any shard
    that was moved ended up requiring a complete rescan which is a bug. This
    just sets the update sequence to the range of the shard being replaced
    rather than zero.
    
    COUCHDB-3055

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fabric issue #62: Use the correct sequence for shard replacement

Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the issue:

    https://github.com/apache/couchdb-fabric/pull/62
  
    Original at https://github.com/cloudant/fabric/commit/daa1b81082ee45d4d54ba5aa9e1852425e438767


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fabric issue #62: Use the correct sequence for shard replacement

Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the issue:

    https://github.com/apache/couchdb-fabric/pull/62
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fabric pull request #62: Use the correct sequence for shard replacem...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/couchdb-fabric/pull/62


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fabric issue #62: Use the correct sequence for shard replacement

Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the issue:

    https://github.com/apache/couchdb-fabric/pull/62
  
    Note, this is _not_ just taking the update seq from one copy of a shard and applying it to another, that would definitely be wrong. Instead, it is passing enough information on that another process will be able to make a safe substitution later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---