You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/04 05:44:38 UTC

[GitHub] [flink] hequn8128 opened a new pull request #8979: [FLINK-13087][table] Add group window Aggregate operator to Table API

hequn8128 opened a new pull request #8979: [FLINK-13087][table] Add group window Aggregate operator to Table API
URL: https://github.com/apache/flink/pull/8979
 
 
   
   ## What is the purpose of the change
   
   This pull request adds row-based group window Aggregate operator to Table API. 
   Also, there are some hotfixes in separate commits. The implementation window aggregate operator depends on some hotfixes, so I didn't create other jiras.
   
   
   ## Brief change log
   
   There are totally 5 commits:
     - [#f5e8d1f](https://github.com/apache/flink/commit/f5e8d1f60a1de4ff69e5e713c4382327c149f33c) Resolve indent problem for `WindowFlatAggregateTableImpl`.
     - [#9395878](https://github.com/apache/flink/commit/939587853716a64c787af17be4610216f9c3b225) Add call support in the group by for row based aggregate. For example, support groupBy('a % b) expressions.
     - [#ee2b065](https://github.com/apache/flink/commit/ee2b06567ef11569dc29fd3c9622fd8afbc49bcc) Throw exceptions if there is a start in the select after window (table)aggregate. Because we don't know which window properties should be selected.
     - [#365f31d](https://github.com/apache/flink/commit/365f31da14376b74dd4a3286dbe0ae17be22d4a6) Validate alias length for aggregate. The alias length should equal to the length of result type.
     - [#deca009](https://github.com/apache/flink/commit/deca0096d4ed9b59718e0a14c8f242bdaaab55d5) Add group window Aggregate operator to Table API
   
   For the last commit: Add group window Aggregate operator to Table API, it mainly contains the following changes
     - Add `aggregate` method to the `WindowGroupedTable`
     - Build `windowAggregate` QueryOperation in `OperationTreeBuilder`
     - Add tests and docs
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - Added plan tests in `AggregateStringExpressionTest`, `AggregateTest`
     - Add validation tests in `GroupWindowValidationTest`
     - Add IT tests in `GroupWindowITCase`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes)
     - If yes, how is the feature documented? (docs)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services