[GitHub] [incubator-tvm] tqchen commented on issue #5050: [CODEGEN] Add support for extern prologue/epilogue functions

[GitBox <gi...@apache.org>]

tqchen commented on issue #5050: [CODEGEN] Add support for extern prologue/epilogue functions
URL: https://github.com/apache/incubator-tvm/pull/5050#issuecomment-598276499
 
 
   Thanks for the contribution. It would be great if we can add an testcase to cover this usecase. In terms of implementations, such intrinsic is better to be lowered before the codegen phase, since they can be lowered to Call blocks, so that we can make use of most codegens(e.g. CodeGenC will work as well).
   
   Given that this is a new feature, it would be useful to open a RFC thread on the https://discuss.tvm.ai/ to let the folks know about it is coming and discuss the API choices. For example I can see quite a few alternatives:
   
   - Since this is more like a call_at_epilogue and call_at_prologue.
   - It can be viewed as a context enter exit calls for a context
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services