You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2018/03/23 23:31:00 UTC
[jira] [Commented] (PHOENIX-4603) Remove check for table existence
in MetaDataClient.createTableInternal()
[ https://issues.apache.org/jira/browse/PHOENIX-4603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412248#comment-16412248 ]
Hudson commented on PHOENIX-4603:
---------------------------------
FAILURE: Integrated in Jenkins build Phoenix-4.x-HBase-0.98 #1842 (See [https://builds.apache.org/job/Phoenix-4.x-HBase-0.98/1842/])
PHOENIX-4603 Remove check for table existence in (jtaylor: rev 41ea571b02ba3f5ed310680260ab9823195f4741)
* (edit) phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
* (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/DynamicColumnIT.java
* (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/NamespaceSchemaMappingIT.java
* (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/MappingTableDataTypeIT.java
> Remove check for table existence in MetaDataClient.createTableInternal()
> ------------------------------------------------------------------------
>
> Key: PHOENIX-4603
> URL: https://issues.apache.org/jira/browse/PHOENIX-4603
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: James Taylor
> Priority: Major
> Fix For: 4.14.0, 5.0.0
>
> Attachments: PHOENIX-4603_v1.patch, PHOENIX-4603_v2.patch
>
>
> Found some strange code in that should be removed. If a table is being created but the HBase metadata already exists, we can't assume one way or the other that it's encoded or not encoded. It's on the user to supply the correct existing encoding in that case.
> {code}
> byte[] tableNameBytes = SchemaUtil.getTableNameAsBytes(schemaName, tableName);
> boolean tableExists = true;
> try {
> HTableDescriptor tableDescriptor = connection.getQueryServices().getTableDescriptor(tableNameBytes);
> if (tableDescriptor == null) { // for connectionless
> tableExists = false;
> }
> } catch (org.apache.phoenix.schema.TableNotFoundException e) {
> tableExists = false;
> }
> if (tableExists) {
> encodingScheme = NON_ENCODED_QUALIFIERS;
> immutableStorageScheme = ONE_CELL_PER_COLUMN;
> } else ...
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)