You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by "Bertrand Delacretaz (Created) (JIRA)" <ji...@apache.org> on 2012/01/18 09:45:40 UTC

[jira] [Created] (FLEX-5) Check and adapt license headers

Check and adapt license headers
-------------------------------

                 Key: FLEX-5
                 URL: https://issues.apache.org/jira/browse/FLEX-5
             Project: Apache Flex
          Issue Type: Sub-task
          Components: Project Management
            Reporter: Bertrand Delacretaz
            Assignee: Bertrand Delacretaz


http://incubator.apache.org/rat/ should be included in the build process to check that source code headers are correct.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (FLEX-33097) Check and adapt license headers

Posted by "Carol Frampton (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLEX-33097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carol Frampton closed FLEX-33097.
---------------------------------

    
> Check and adapt license headers
> -------------------------------
>
>                 Key: FLEX-33097
>                 URL: https://issues.apache.org/jira/browse/FLEX-33097
>             Project: Apache Flex
>          Issue Type: Sub-task
>          Components: Project Management
>            Reporter: Bertrand Delacretaz
>             Fix For: Apache Flex 4.8 (parity release)
>
>
> http://incubator.apache.org/rat/ should be included in the build process to check that source code headers are correct.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (FLEX-33097) Check and adapt license headers

Posted by "Carol Frampton (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLEX-33097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carol Frampton resolved FLEX-33097.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: Apache Flex 4.8 (parity release)

RAT was used to prepare the Flex 4.8.0 release.
                
> Check and adapt license headers
> -------------------------------
>
>                 Key: FLEX-33097
>                 URL: https://issues.apache.org/jira/browse/FLEX-33097
>             Project: Apache Flex
>          Issue Type: Sub-task
>          Components: Project Management
>            Reporter: Bertrand Delacretaz
>             Fix For: Apache Flex 4.8 (parity release)
>
>
> http://incubator.apache.org/rat/ should be included in the build process to check that source code headers are correct.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Re: [jira] [Created] (FLEX-5) Check and adapt license headers

Posted by Alex Harui <ah...@adobe.com>.
We used an in-house scrubbing tool to verify that all headers with Adobe
copyrights now said Apache and to convince legal that we had permission from
any third party contributors to submit this code to Apache.

I assume RAT works the same way, and may catch other issues that matter to
Apache.

-Alex

On 1/18/12 1:00 PM, "Rick Winscot" <ri...@gmail.com> wrote:

> Bertrand
> 
> All the old Adobe copyright / headers are null and void... visual confirmation
> that the old headers are removed and new headers are added and properly
> displayed... is what I was thinking.
> 
> Is adobe expected to scrub the source before they commit it?

-- 
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui


Re: [jira] [Created] (FLEX-5) Check and adapt license headers

Posted by Carol Frampton <cf...@adobe.com>.
Rick,

As I said all of the old Adobe headers are gone in the code we are
donating. While Apache would have let us fix these during the incubation
period, Adobe legal wanted them fixed before the donation.

I used the Apache provided tool for inserting the new Apache headers.
There may be a few files with odd file types that the Apache script didn't
know about that I missed that will need to be corrected.

Carol

 
On 1/18/12 4 :00PM, "Rick Winscot" <ri...@gmail.com> wrote:

>Bertrand
>
>All the old Adobe copyright / headers are null and void... visual
>confirmation that the old headers are removed and new headers are added
>and properly displayed... is what I was thinking.
>
>Is adobe expected to scrub the source before they commit it?
>
>-- 
>Rick Winscot
>
>
>On Wednesday, January 18, 2012 at 12:57 PM, Bertrand Delacretaz wrote:
>
>> On Wed, Jan 18, 2012 at 6:16 PM, Rick Winscot <rick.winscot@gmail.com
>>(mailto:rick.winscot@gmail.com)> wrote:
>> > I'd like to volunteer for the grunt work of visual confirmation - I
>>would generate a list of any files committed that do not meet the Apache
>>requirement. I would then pass that list to PPMC to make adjustments as
>>needed...
>> 
>> 
>> Note that with http://incubator.apache.org/rat/ integrated in the Flex
>> build, there should be no need for visual confirmation. In the end,
>> and exclusions file for that tool, checked into svn, that tells it
>> which files are ok not to have the Apache header, is all that needs to
>> be checked.
>> 
>> So instead of boring visual confirmation work, you might volunteer to
>> integrate rat into the build ;-)
>> 
>> -Bertrand 
>


Re: [jira] [Created] (FLEX-5) Check and adapt license headers

Posted by Rick Winscot <ri...@gmail.com>.
Bertrand

All the old Adobe copyright / headers are null and void... visual confirmation that the old headers are removed and new headers are added and properly displayed... is what I was thinking.

Is adobe expected to scrub the source before they commit it? 

-- 
Rick Winscot


On Wednesday, January 18, 2012 at 12:57 PM, Bertrand Delacretaz wrote:

> On Wed, Jan 18, 2012 at 6:16 PM, Rick Winscot <rick.winscot@gmail.com (mailto:rick.winscot@gmail.com)> wrote:
> > I'd like to volunteer for the grunt work of visual confirmation - I would generate a list of any files committed that do not meet the Apache requirement. I would then pass that list to PPMC to make adjustments as needed...
> 
> 
> Note that with http://incubator.apache.org/rat/ integrated in the Flex
> build, there should be no need for visual confirmation. In the end,
> and exclusions file for that tool, checked into svn, that tells it
> which files are ok not to have the Apache header, is all that needs to
> be checked.
> 
> So instead of boring visual confirmation work, you might volunteer to
> integrate rat into the build ;-)
> 
> -Bertrand 


Re: [jira] [Created] (FLEX-5) Check and adapt license headers

Posted by Carol Frampton <cf...@adobe.com>.
>
>So instead of boring visual confirmation work, you might volunteer to
>integrate rat into the build ;-)
>

I will do that.

Carol


Re: [jira] [Created] (FLEX-5) Check and adapt license headers

Posted by Bertrand Delacretaz <bd...@apache.org>.
On Wed, Jan 18, 2012 at 6:16 PM, Rick Winscot <ri...@gmail.com> wrote:
> I'd like to volunteer for the grunt work of visual confirmation - I would generate a list of any files committed that do not meet the Apache requirement. I would then pass that list to PPMC to make adjustments as needed...

Note that with http://incubator.apache.org/rat/ integrated in the Flex
build, there should be no need for visual confirmation. In the end,
and exclusions file for that tool, checked into svn, that tells it
which files are ok not to have the Apache header, is all that needs to
be checked.

So instead of boring visual confirmation work, you might volunteer to
integrate rat into the build ;-)

-Bertrand

Re: [jira] [Created] (FLEX-5) Check and adapt license headers

Posted by Rick Winscot <ri...@gmail.com>.
I'd like to volunteer for the grunt work of visual confirmation - I would generate a list of any files committed that do not meet the Apache requirement. I would then pass that list to PPMC to make adjustments as needed.


-- 
Rick Winscot


On Wednesday, January 18, 2012 at 11:17 AM, Carol Frampton wrote:

> The majority/all the code will be deposited in the apache repository with
> Apache headers. We will need to do a final pass to make sure we didn't
> miss any files.
> 
> Carol
> 
> 
> On 1/18/12 3 :45AM, "Bertrand Delacretaz (Created) (JIRA)"
> <jira@apache.org (mailto:jira@apache.org)> wrote:
> 
> > Check and adapt license headers
> > -------------------------------
> > 
> > Key: FLEX-5
> > URL: https://issues.apache.org/jira/browse/FLEX-5
> > Project: Apache Flex
> > Issue Type: Sub-task
> > Components: Project Management
> > Reporter: Bertrand Delacretaz
> > Assignee: Bertrand Delacretaz
> > 
> > 
> > http://incubator.apache.org/rat/ should be included in the build process
> > to check that source code headers are correct.
> > 
> > --
> > This message is automatically generated by JIRA.
> > If you think it was sent incorrectly, please contact your JIRA
> > administrators: 
> > https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> > For more information on JIRA, see: http://www.atlassian.com/software/jira
> > 


Re: [jira] [Created] (FLEX-5) Check and adapt license headers

Posted by Carol Frampton <cf...@adobe.com>.
The majority/all the code will be deposited in the apache repository with
Apache headers.  We will need to do a final pass to make sure we didn't
miss any files.

Carol


On 1/18/12 3 :45AM, "Bertrand Delacretaz (Created) (JIRA)"
<ji...@apache.org> wrote:

>Check and adapt license headers
>-------------------------------
>
>                 Key: FLEX-5
>                 URL: https://issues.apache.org/jira/browse/FLEX-5
>             Project: Apache Flex
>          Issue Type: Sub-task
>          Components: Project Management
>            Reporter: Bertrand Delacretaz
>            Assignee: Bertrand Delacretaz
>
>
>http://incubator.apache.org/rat/ should be included in the build process
>to check that source code headers are correct.
>
>--
>This message is automatically generated by JIRA.
>If you think it was sent incorrectly, please contact your JIRA
>administrators: 
>https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>        


[jira] [Updated] (FLEX-5) Check and adapt license headers

Posted by "Bertrand Delacretaz (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FLEX-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bertrand Delacretaz updated FLEX-5:
-----------------------------------

    Assignee:     (was: Bertrand Delacretaz)
    
> Check and adapt license headers
> -------------------------------
>
>                 Key: FLEX-5
>                 URL: https://issues.apache.org/jira/browse/FLEX-5
>             Project: Apache Flex
>          Issue Type: Sub-task
>          Components: Project Management
>            Reporter: Bertrand Delacretaz
>
> http://incubator.apache.org/rat/ should be included in the build process to check that source code headers are correct.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira