You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Jonathan Robie <jo...@redhat.com> on 2010/05/07 20:33:06 UTC

JMS Selectors - what to document?

I'm not sure how best to document JMS selectors in the Java client.

Java JMS defines selectors here:
http://java.sun.com/j2ee/1.4/docs/api/javax/jms/Message.html

I've heard that what we have implemented is not exactly that, but 
corresponds to the JMS Selector BNF I used here:
http://people.apache.org/~jonathan/Programming-In-Apache-Qpid.html#id3015749

How much of this is true? Just exactly what should be documented here?

Jonathan

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org

Re: JMS Selectors - what to document?

Posted by Martin Ritchie <ri...@apache.org>.
On 10 May 2010 10:47, Gordon Sim <gs...@redhat.com> wrote:
> On 05/07/2010 07:33 PM, Jonathan Robie wrote:
>>
>> I'm not sure how best to document JMS selectors in the Java client.
>>
>> Java JMS defines selectors here:
>> http://java.sun.com/j2ee/1.4/docs/api/javax/jms/Message.html
>>
>> I've heard that what we have implemented is not exactly that, but
>> corresponds to the JMS Selector BNF I used here:
>>
>> http://people.apache.org/~jonathan/Programming-In-Apache-Qpid.html#id3015749
>
> If there is indeed some aspect of Qpid's support that differs from the
> specification we should highlight that explicitly[1]. A grammar is not the
> most useful way of documenting any differences. If there isn't then lets not
> confuse the picture.
>
> [1] we should also have a Jira for any differences that would affect
> compliance and resolve those as we are able

We should also provide feedback to ActiveMQ of any deviation from the
JMS Spec as the selector implementation was lifted from their code
base.

Martin

> ---------------------------------------------------------------------
> Apache Qpid - AMQP Messaging Implementation
> Project:      http://qpid.apache.org
> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>
>



-- 
Martin Ritchie

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org

Re: JMS Selectors - what to document?

Posted by Jonathan Robie <jo...@redhat.com>.
On 05/10/2010 07:46 AM, Gordon Sim wrote:
> On 05/10/2010 11:40 AM, Andrew Kennedy wrote:
>> The javacc grammar on the broker implements the extra non-standard
>> selector tokens XPATH and XQUERY, which came from Active MQ initially,
>> although they aren't mentioned in the client-side grammar...
>
> Thanks, thats useful to know.
>
> My guess is that neither of those are currently implemented in 
> Qpid(?). My inclination would be to remove that section 3.5 entirely.

Unless someone objects, and tells me what to document for JMS selectors, 
I'm going to remove that section.

> On a separate point we should note that the support for nested 
> lists/maps in the Qpid JMS MapMessage implementation is not standard 
> JMS. May also be worth mentioning the setting that controls which 
> format is used.

What setting is that?

I've already added a footnote saying that nested maps are not standard 
JMS. I'll add a similar note for nested lists.

Jonathan


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org

Re: JMS Selectors - what to document?

Posted by Gordon Sim <gs...@redhat.com>.
On 05/10/2010 11:40 AM, Andrew Kennedy wrote:
> On 10 May 2010 10:47, Gordon Sim<gs...@redhat.com>  wrote:
>> On 05/07/2010 07:33 PM, Jonathan Robie wrote:
>>>
>>> I'm not sure how best to document JMS selectors in the Java client.
>>>
>>> Java JMS defines selectors here:
>>> http://java.sun.com/j2ee/1.4/docs/api/javax/jms/Message.html
>>>
>>> I've heard that what we have implemented is not exactly that, but
>>> corresponds to the JMS Selector BNF I used here:
>>>
>>> http://people.apache.org/~jonathan/Programming-In-Apache-Qpid.html#id3015749
>>
>> If there is indeed some aspect of Qpid's support that differs from the
>> specification we should highlight that explicitly[1]. A grammar is not the
>> most useful way of documenting any differences. If there isn't then lets not
>> confuse the picture.
>
> The javacc grammar on the broker implements the extra non-standard
> selector tokens XPATH and XQUERY, which came from Active MQ initially,
> although they aren't mentioned in the client-side grammar...

Thanks, thats useful to know.

My guess is that neither of those are currently implemented in Qpid(?). 
My inclination would be to remove that section 3.5 entirely.

On a separate point we should note that the support for nested 
lists/maps in the Qpid JMS MapMessage implementation is not standard 
JMS. May also be worth mentioning the setting that controls which format 
is used.

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org

Re: JMS Selectors - what to document?

Posted by Andrew Kennedy <an...@gmail.com>.
On 10 May 2010 10:47, Gordon Sim <gs...@redhat.com> wrote:
> On 05/07/2010 07:33 PM, Jonathan Robie wrote:
>>
>> I'm not sure how best to document JMS selectors in the Java client.
>>
>> Java JMS defines selectors here:
>> http://java.sun.com/j2ee/1.4/docs/api/javax/jms/Message.html
>>
>> I've heard that what we have implemented is not exactly that, but
>> corresponds to the JMS Selector BNF I used here:
>>
>> http://people.apache.org/~jonathan/Programming-In-Apache-Qpid.html#id3015749
>
> If there is indeed some aspect of Qpid's support that differs from the
> specification we should highlight that explicitly[1]. A grammar is not the
> most useful way of documenting any differences. If there isn't then lets not
> confuse the picture.

The javacc grammar on the broker implements the extra non-standard
selector tokens XPATH and XQUERY, which came from Active MQ initially,
although they aren't mentioned in the client-side grammar...

> [1] we should also have a Jira for any differences that would affect
> compliance and resolve those as we are able

Andrew.
-- 
-- andrew d kennedy ? edinburgh : +44 7941 197 134

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org

Re: JMS Selectors - what to document?

Posted by Gordon Sim <gs...@redhat.com>.
On 05/07/2010 07:33 PM, Jonathan Robie wrote:
> I'm not sure how best to document JMS selectors in the Java client.
>
> Java JMS defines selectors here:
> http://java.sun.com/j2ee/1.4/docs/api/javax/jms/Message.html
>
> I've heard that what we have implemented is not exactly that, but
> corresponds to the JMS Selector BNF I used here:
> http://people.apache.org/~jonathan/Programming-In-Apache-Qpid.html#id3015749

If there is indeed some aspect of Qpid's support that differs from the 
specification we should highlight that explicitly[1]. A grammar is not 
the most useful way of documenting any differences. If there isn't then 
lets not confuse the picture.

[1] we should also have a Jira for any differences that would affect 
compliance and resolve those as we are able

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org