You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Vamsavardhana Reddy (JIRA)" <de...@geronimo.apache.org> on 2006/10/03 19:41:19 UTC
[jira] Created: (GERONIMO-2458) MapEditor does not work
MapEditor does not work
-----------------------
Key: GERONIMO-2458
URL: http://issues.apache.org/jira/browse/GERONIMO-2458
Project: Geronimo
Issue Type: Bug
Security Level: public (Regular issues)
Components: common
Affects Versions: 1.1.1, 1.2
Environment: 1.2-SNAPSHOT
Reporter: Vamsavardhana Reddy
Fix For: 1.1.2, 1.2
MapEditor.getAsText() is returning map.toString() which is not in sync with setAsText() that expects input in the form name1=value1 on separate lines.
Bottom line...
MapEditor.getAsText() returns
{name1=value1, name2=value2}
where as MapEditor.setAsText() expects
name1=value1
name=value2
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-2458) MapEditor does not work
Posted by "Vamsavardhana Reddy (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2458?page=all ]
Vamsavardhana Reddy updated GERONIMO-2458:
------------------------------------------
Attachment: GERONIMO-2458.patch
GERONIMO-2458.patch: Fixes the problem by making MapEditor use PropertiesEditor.
> MapEditor does not work
> -----------------------
>
> Key: GERONIMO-2458
> URL: http://issues.apache.org/jira/browse/GERONIMO-2458
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: common
> Affects Versions: 1.1.1, 1.2
> Environment: 1.2-SNAPSHOT
> Reporter: Vamsavardhana Reddy
> Fix For: 1.2, 1.1.2
>
> Attachments: GERONIMO-2458.patch
>
>
> MapEditor.getAsText() is returning map.toString() which is not in sync with setAsText() that expects input in the form name1=value1 on separate lines.
> Bottom line...
> MapEditor.getAsText() returns
> {name1=value1, name2=value2}
> where as MapEditor.setAsText() expects
> name1=value1
> name=value2
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-2458) MapEditor does not work
Posted by "Vamsavardhana Reddy (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2458?page=all ]
Vamsavardhana Reddy updated GERONIMO-2458:
------------------------------------------
Fix Version/s: 2.0
Assignee: Vamsavardhana Reddy
> MapEditor does not work
> -----------------------
>
> Key: GERONIMO-2458
> URL: http://issues.apache.org/jira/browse/GERONIMO-2458
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: common
> Affects Versions: 1.1.1, 1.2
> Environment: 1.2-SNAPSHOT
> Reporter: Vamsavardhana Reddy
> Assigned To: Vamsavardhana Reddy
> Fix For: 1.2, 1.1.2, 2.0
>
> Attachments: GERONIMO-2458.patch
>
>
> MapEditor.getAsText() is returning map.toString() which is not in sync with setAsText() that expects input in the form name1=value1 on separate lines.
> Bottom line...
> MapEditor.getAsText() returns
> {name1=value1, name2=value2}
> where as MapEditor.setAsText() expects
> name1=value1
> name=value2
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (GERONIMO-2458) MapEditor does not work
Posted by "Vamsavardhana Reddy (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2458?page=all ]
Vamsavardhana Reddy closed GERONIMO-2458.
-----------------------------------------
Resolution: Fixed
Use PropertiesEditor. Replace null keys and values with empty string.
Fixed in rev 479580 (branches\1.1), rev 479585 (branches\1.2) and rev 479586 (trunk).
> MapEditor does not work
> -----------------------
>
> Key: GERONIMO-2458
> URL: http://issues.apache.org/jira/browse/GERONIMO-2458
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: common
> Affects Versions: 1.1.1, 1.2
> Environment: 1.2-SNAPSHOT
> Reporter: Vamsavardhana Reddy
> Assigned To: Vamsavardhana Reddy
> Fix For: 1.1.2, 1.2, 2.0
>
> Attachments: GERONIMO-2458.patch
>
>
> MapEditor.getAsText() is returning map.toString() which is not in sync with setAsText() that expects input in the form name1=value1 on separate lines.
> Bottom line...
> MapEditor.getAsText() returns
> {name1=value1, name2=value2}
> where as MapEditor.setAsText() expects
> name1=value1
> name=value2
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2458) MapEditor does not work
Posted by "Vamsavardhana Reddy (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2458?page=comments#action_12440018 ]
Vamsavardhana Reddy commented on GERONIMO-2458:
-----------------------------------------------
The current MapEditor won't work at all. Whereas the fix I submitted is alright as long as there are no null keys or values. I agree that my patch will make the class equivalent to "MapEditor extends PropertiesEditor" with nothing extra.
Maps can have null keys & values and null mapped to null. Keys and values need not be Strings. MapEditor should handle all these scenarios. I submitted the patch with the idea that I will sumbit another patch later to handle nulls etc.
Each key and its corresponding value in Properties is a String.
If we will not be handling non-string properties or values and nulls in maps in G, we can remove this class altogether and use PropertiesEditor alone.
> MapEditor does not work
> -----------------------
>
> Key: GERONIMO-2458
> URL: http://issues.apache.org/jira/browse/GERONIMO-2458
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: common
> Affects Versions: 1.1.1, 1.2
> Environment: 1.2-SNAPSHOT
> Reporter: Vamsavardhana Reddy
> Fix For: 1.1.2, 1.2
>
> Attachments: GERONIMO-2458.patch
>
>
> MapEditor.getAsText() is returning map.toString() which is not in sync with setAsText() that expects input in the form name1=value1 on separate lines.
> Bottom line...
> MapEditor.getAsText() returns
> {name1=value1, name2=value2}
> where as MapEditor.setAsText() expects
> name1=value1
> name=value2
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2458) MapEditor does not work
Posted by "Jason Dillon (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2458?page=comments#action_12439953 ]
Jason Dillon commented on GERONIMO-2458:
----------------------------------------
Why not just change MapEditor to extend from PropertiesEditor?
> MapEditor does not work
> -----------------------
>
> Key: GERONIMO-2458
> URL: http://issues.apache.org/jira/browse/GERONIMO-2458
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: common
> Affects Versions: 1.2, 1.1.1
> Environment: 1.2-SNAPSHOT
> Reporter: Vamsavardhana Reddy
> Fix For: 1.2, 1.1.2
>
> Attachments: GERONIMO-2458.patch
>
>
> MapEditor.getAsText() is returning map.toString() which is not in sync with setAsText() that expects input in the form name1=value1 on separate lines.
> Bottom line...
> MapEditor.getAsText() returns
> {name1=value1, name2=value2}
> where as MapEditor.setAsText() expects
> name1=value1
> name=value2
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira