You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Thomas Singer (JIRA)" <ji...@apache.org> on 2007/05/22 15:24:16 UTC
[jira] Created: (WICKET-584) Use consistent naming for boolean
getters
Use consistent naming for boolean getters
-----------------------------------------
Key: WICKET-584
URL: https://issues.apache.org/jira/browse/WICKET-584
Project: Wicket
Issue Type: Task
Reporter: Thomas Singer
For example: in ComponentTag there exist isAutoLink(), isOpen(), isClose() but in IMarkupSettings there are getAutomaticLinking(), getCompressWhitespace() or getStripComments().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WICKET-584) Use consistent naming for boolean
getters
Posted by "Jonathan Locke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Locke closed WICKET-584.
---------------------------------
> Use consistent naming for boolean getters
> -----------------------------------------
>
> Key: WICKET-584
> URL: https://issues.apache.org/jira/browse/WICKET-584
> Project: Wicket
> Issue Type: Task
> Affects Versions: 1.3.0-beta1
> Reporter: Thomas Singer
> Assigned To: Jonathan Locke
> Priority: Minor
>
> For example: in ComponentTag there exist isAutoLink(), isOpen(), isClose() but in IMarkupSettings there are getAutomaticLinking(), getCompressWhitespace() or getStripComments().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-584) Use consistent naming for boolean
getters
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Compagner reassigned WICKET-584:
--------------------------------------
Assignee: Jonathan Locke
I think this is really jonathans area of expertise!
> Use consistent naming for boolean getters
> -----------------------------------------
>
> Key: WICKET-584
> URL: https://issues.apache.org/jira/browse/WICKET-584
> Project: Wicket
> Issue Type: Task
> Affects Versions: 1.3.0-beta1
> Reporter: Thomas Singer
> Assigned To: Jonathan Locke
> Priority: Minor
>
> For example: in ComponentTag there exist isAutoLink(), isOpen(), isClose() but in IMarkupSettings there are getAutomaticLinking(), getCompressWhitespace() or getStripComments().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-584) Use consistent naming for boolean
getters
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw updated WICKET-584:
--------------------------------
Priority: Minor (was: Major)
Affects Version/s: 1.3.0-beta1
There are many places where this is an issue. For example, Component uses get* on some of its flags, but is* on others.
The Settings code is all get*
The problem is that changing all these will break a bunch of code out there and annoy a lot of people. We could leave deprecated delegate methods behind, I guess, but I'm not sure the faff is worth it, and that won't work well with interfaces like IFormSubmittingComponent.
> Use consistent naming for boolean getters
> -----------------------------------------
>
> Key: WICKET-584
> URL: https://issues.apache.org/jira/browse/WICKET-584
> Project: Wicket
> Issue Type: Task
> Affects Versions: 1.3.0-beta1
> Reporter: Thomas Singer
> Priority: Minor
>
> For example: in ComponentTag there exist isAutoLink(), isOpen(), isClose() but in IMarkupSettings there are getAutomaticLinking(), getCompressWhitespace() or getStripComments().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-584) Use consistent naming for boolean
getters
Posted by "Jonathan Locke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Locke resolved WICKET-584.
-----------------------------------
Resolution: Won't Fix
I think we should open new bugs about specific bad names. Converting everything to isX doesn't fix any problem and makes the code less readable so I'm closing this won't fix.
> Use consistent naming for boolean getters
> -----------------------------------------
>
> Key: WICKET-584
> URL: https://issues.apache.org/jira/browse/WICKET-584
> Project: Wicket
> Issue Type: Task
> Affects Versions: 1.3.0-beta1
> Reporter: Thomas Singer
> Assigned To: Jonathan Locke
> Priority: Minor
>
> For example: in ComponentTag there exist isAutoLink(), isOpen(), isClose() but in IMarkupSettings there are getAutomaticLinking(), getCompressWhitespace() or getStripComments().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-584) Use consistent naming for boolean
getters
Posted by "Thomas Singer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12497878 ]
Thomas Singer commented on WICKET-584:
--------------------------------------
I'm aware of these problems, but it shouldn't be that big anymore like a couple of years ago when IDEs did not know what refactoring is.
> Use consistent naming for boolean getters
> -----------------------------------------
>
> Key: WICKET-584
> URL: https://issues.apache.org/jira/browse/WICKET-584
> Project: Wicket
> Issue Type: Task
> Affects Versions: 1.3.0-beta1
> Reporter: Thomas Singer
> Assigned To: Jonathan Locke
> Priority: Minor
>
> For example: in ComponentTag there exist isAutoLink(), isOpen(), isClose() but in IMarkupSettings there are getAutomaticLinking(), getCompressWhitespace() or getStripComments().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-584) Use consistent naming for boolean
getters
Posted by "Jonathan Locke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498081 ]
Jonathan Locke commented on WICKET-584:
---------------------------------------
I don't agree that "inconsistent" naming of boolean methods is a "problem". It is perfectly valid to have both isX methods and getX methods that return booleans (according to the JavaBeans spec). We should be using the naming that makes sense in English and not be rigorously sticking to isX (which is not now and never has been a "standard" for boolean values). getAutomaticLinking is definitely better than isAutomaticLinking, but the best there might be isAutomaticLinkingEnabled. getCompressWhitespace OTOH is a PERFECTLY VALID name for this property. In fact, it's the best name for the property and I see no reason to change it. Truth is there methods are case-by-case. I think we should close this bug and then reopen new bugs for specific cases of UNGRAMMATICAL boolean getter methods.
> Use consistent naming for boolean getters
> -----------------------------------------
>
> Key: WICKET-584
> URL: https://issues.apache.org/jira/browse/WICKET-584
> Project: Wicket
> Issue Type: Task
> Affects Versions: 1.3.0-beta1
> Reporter: Thomas Singer
> Assigned To: Jonathan Locke
> Priority: Minor
>
> For example: in ComponentTag there exist isAutoLink(), isOpen(), isClose() but in IMarkupSettings there are getAutomaticLinking(), getCompressWhitespace() or getStripComments().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.