You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2015/10/13 23:30:40 UTC

Review Request 39293: Finalization Fails After Manual Upgrade Because of Cluster Version State Set To UPGRADING

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39293/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Nate Cole, and Sumit Mohanty.


Bugs: AMBARI-13413
    https://issues.apache.org/jira/browse/AMBARI-13413


Repository: ambari


Description
-------

After manual upgrade from HDP 2.3.0 to HDP 2.3.2, all {{host_version}} upgraded to 2.3.2 with the {{UPGRADED}} state, but the {{cluster_version}} is stuck at {{UPGRADING}}.

{code}
[root@falconk1 lib]# ambari-server set-current --cluster-name=falconK --version-display-name=HDP-2.3.2.0-2950
Using python  /usr/bin/python2.6
Setting current version...
Enter Ambari Admin login: admin
Enter Ambari Admin password:
ERROR: Exiting with exit code 1.
REASON: Error during setting current version. Http status code - 500.
 {
  "status" : 500,
  "message" : "org.apache.ambari.server.controller.spi.SystemException: Finalization failed. More details: \nSTDOUT: Begin finalizing the upgrade of cluster falconK to version 2.3.2.0-2950\n\nSTDERR: The cluster stack version state UPGRADING is not allowed to transition directly into CURRENT"
}
{code}


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 53e985e 
  ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 79d2355 

Diff: https://reviews.apache.org/r/39293/diff/


Testing
-------

mvn clean test

Tests run: 3261, Failures: 0, Errors: 0, Skipped: 35

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 27:25 min
[INFO] Finished at: 2015-10-13T14:12:59-04:00
[INFO] Final Memory: 34M/1389M


Thanks,

Jonathan Hurley


Re: Review Request 39293: Finalization Fails After Manual Upgrade Because of Cluster Version State Set To UPGRADING

Posted by Jonathan Hurley <jh...@hortonworks.com>.

> On Oct. 13, 2015, 5:49 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java, line 190
> > <https://reviews.apache.org/r/39293/diff/1/?file=1097845#file1097845line190>
> >
> >     What about hosts in UPGRADING because they still have components that are not on the newer version.
> >     
> >     We need to add that host to hostsWithoutCorrectVersionState if haveAllComponentsFinishedAdvertisingVersion is false.

Thanks for that.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39293/#review102538
-----------------------------------------------------------


On Oct. 13, 2015, 5:30 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39293/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 5:30 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-13413
>     https://issues.apache.org/jira/browse/AMBARI-13413
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> After manual upgrade from HDP 2.3.0 to HDP 2.3.2, all {{host_version}} upgraded to 2.3.2 with the {{UPGRADED}} state, but the {{cluster_version}} is stuck at {{UPGRADING}}.
> 
> {code}
> [root@falconk1 lib]# ambari-server set-current --cluster-name=falconK --version-display-name=HDP-2.3.2.0-2950
> Using python  /usr/bin/python2.6
> Setting current version...
> Enter Ambari Admin login: admin
> Enter Ambari Admin password:
> ERROR: Exiting with exit code 1.
> REASON: Error during setting current version. Http status code - 500.
>  {
>   "status" : 500,
>   "message" : "org.apache.ambari.server.controller.spi.SystemException: Finalization failed. More details: \nSTDOUT: Begin finalizing the upgrade of cluster falconK to version 2.3.2.0-2950\n\nSTDERR: The cluster stack version state UPGRADING is not allowed to transition directly into CURRENT"
> }
> {code}
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 53e985e 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 79d2355 
> 
> Diff: https://reviews.apache.org/r/39293/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> Tests run: 3261, Failures: 0, Errors: 0, Skipped: 35
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 27:25 min
> [INFO] Finished at: 2015-10-13T14:12:59-04:00
> [INFO] Final Memory: 34M/1389M
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Re: Review Request 39293: Finalization Fails After Manual Upgrade Because of Cluster Version State Set To UPGRADING

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39293/#review102538
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java (line 188)
<https://reviews.apache.org/r/39293/#comment160238>

    What about hosts in UPGRADING because they still have components that are not on the newer version.
    
    We need to add that host to hostsWithoutCorrectVersionState if haveAllComponentsFinishedAdvertisingVersion is false.


- Alejandro Fernandez


On Oct. 13, 2015, 9:30 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39293/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 9:30 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-13413
>     https://issues.apache.org/jira/browse/AMBARI-13413
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> After manual upgrade from HDP 2.3.0 to HDP 2.3.2, all {{host_version}} upgraded to 2.3.2 with the {{UPGRADED}} state, but the {{cluster_version}} is stuck at {{UPGRADING}}.
> 
> {code}
> [root@falconk1 lib]# ambari-server set-current --cluster-name=falconK --version-display-name=HDP-2.3.2.0-2950
> Using python  /usr/bin/python2.6
> Setting current version...
> Enter Ambari Admin login: admin
> Enter Ambari Admin password:
> ERROR: Exiting with exit code 1.
> REASON: Error during setting current version. Http status code - 500.
>  {
>   "status" : 500,
>   "message" : "org.apache.ambari.server.controller.spi.SystemException: Finalization failed. More details: \nSTDOUT: Begin finalizing the upgrade of cluster falconK to version 2.3.2.0-2950\n\nSTDERR: The cluster stack version state UPGRADING is not allowed to transition directly into CURRENT"
> }
> {code}
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 53e985e 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 79d2355 
> 
> Diff: https://reviews.apache.org/r/39293/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> Tests run: 3261, Failures: 0, Errors: 0, Skipped: 35
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 27:25 min
> [INFO] Finished at: 2015-10-13T14:12:59-04:00
> [INFO] Final Memory: 34M/1389M
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Re: Review Request 39293: Finalization Fails After Manual Upgrade Because of Cluster Version State Set To UPGRADING

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39293/#review102554
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On Oct. 13, 2015, 10:08 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39293/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 10:08 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-13413
>     https://issues.apache.org/jira/browse/AMBARI-13413
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> After manual upgrade from HDP 2.3.0 to HDP 2.3.2, all {{host_version}} upgraded to 2.3.2 with the {{UPGRADED}} state, but the {{cluster_version}} is stuck at {{UPGRADING}}.
> 
> {code}
> [root@falconk1 lib]# ambari-server set-current --cluster-name=falconK --version-display-name=HDP-2.3.2.0-2950
> Using python  /usr/bin/python2.6
> Setting current version...
> Enter Ambari Admin login: admin
> Enter Ambari Admin password:
> ERROR: Exiting with exit code 1.
> REASON: Error during setting current version. Http status code - 500.
>  {
>   "status" : 500,
>   "message" : "org.apache.ambari.server.controller.spi.SystemException: Finalization failed. More details: \nSTDOUT: Begin finalizing the upgrade of cluster falconK to version 2.3.2.0-2950\n\nSTDERR: The cluster stack version state UPGRADING is not allowed to transition directly into CURRENT"
> }
> {code}
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 53e985e 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 79d2355 
> 
> Diff: https://reviews.apache.org/r/39293/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> Tests run: 3261, Failures: 0, Errors: 0, Skipped: 35
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 27:25 min
> [INFO] Finished at: 2015-10-13T14:12:59-04:00
> [INFO] Final Memory: 34M/1389M
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Re: Review Request 39293: Finalization Fails After Manual Upgrade Because of Cluster Version State Set To UPGRADING

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39293/#review102577
-----------------------------------------------------------

Ship it!


Ship It!

- Jayush Luniya


On Oct. 13, 2015, 10:08 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39293/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 10:08 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-13413
>     https://issues.apache.org/jira/browse/AMBARI-13413
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> After manual upgrade from HDP 2.3.0 to HDP 2.3.2, all {{host_version}} upgraded to 2.3.2 with the {{UPGRADED}} state, but the {{cluster_version}} is stuck at {{UPGRADING}}.
> 
> {code}
> [root@falconk1 lib]# ambari-server set-current --cluster-name=falconK --version-display-name=HDP-2.3.2.0-2950
> Using python  /usr/bin/python2.6
> Setting current version...
> Enter Ambari Admin login: admin
> Enter Ambari Admin password:
> ERROR: Exiting with exit code 1.
> REASON: Error during setting current version. Http status code - 500.
>  {
>   "status" : 500,
>   "message" : "org.apache.ambari.server.controller.spi.SystemException: Finalization failed. More details: \nSTDOUT: Begin finalizing the upgrade of cluster falconK to version 2.3.2.0-2950\n\nSTDERR: The cluster stack version state UPGRADING is not allowed to transition directly into CURRENT"
> }
> {code}
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 53e985e 
>   ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 79d2355 
> 
> Diff: https://reviews.apache.org/r/39293/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> Tests run: 3261, Failures: 0, Errors: 0, Skipped: 35
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 27:25 min
> [INFO] Finished at: 2015-10-13T14:12:59-04:00
> [INFO] Final Memory: 34M/1389M
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Re: Review Request 39293: Finalization Fails After Manual Upgrade Because of Cluster Version State Set To UPGRADING

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39293/
-----------------------------------------------------------

(Updated Oct. 13, 2015, 6:08 p.m.)


Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Nate Cole, and Sumit Mohanty.


Bugs: AMBARI-13413
    https://issues.apache.org/jira/browse/AMBARI-13413


Repository: ambari


Description
-------

After manual upgrade from HDP 2.3.0 to HDP 2.3.2, all {{host_version}} upgraded to 2.3.2 with the {{UPGRADED}} state, but the {{cluster_version}} is stuck at {{UPGRADING}}.

{code}
[root@falconk1 lib]# ambari-server set-current --cluster-name=falconK --version-display-name=HDP-2.3.2.0-2950
Using python  /usr/bin/python2.6
Setting current version...
Enter Ambari Admin login: admin
Enter Ambari Admin password:
ERROR: Exiting with exit code 1.
REASON: Error during setting current version. Http status code - 500.
 {
  "status" : 500,
  "message" : "org.apache.ambari.server.controller.spi.SystemException: Finalization failed. More details: \nSTDOUT: Begin finalizing the upgrade of cluster falconK to version 2.3.2.0-2950\n\nSTDERR: The cluster stack version state UPGRADING is not allowed to transition directly into CURRENT"
}
{code}


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 53e985e 
  ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 79d2355 

Diff: https://reviews.apache.org/r/39293/diff/


Testing
-------

mvn clean test

Tests run: 3261, Failures: 0, Errors: 0, Skipped: 35

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 27:25 min
[INFO] Finished at: 2015-10-13T14:12:59-04:00
[INFO] Final Memory: 34M/1389M


Thanks,

Jonathan Hurley