[GitHub] [iotdb] HTHou commented on a change in pull request #1846: [IOTDB-872] Use system timezone in CLI (Session)

[GitBox <gi...@apache.org>]

HTHou commented on a change in pull request #1846:
URL: https://github.com/apache/iotdb/pull/1846#discussion_r512434392



##########
File path: session/src/test/java/org/apache/iotdb/session/pool/SessionPoolTest.java
##########
@@ -163,7 +163,7 @@ private void correctQuery(SessionPool pool) {
 
   @Test
   public void tryIfTheServerIsRestart() {
-    SessionPool pool = new SessionPool("127.0.0.1", 6667, "root", "root", 3, 1, 6000, false);
+    SessionPool pool = new SessionPool("127.0.0.1", 6667, "root", "root", 3, 1, 6000, false, null);

Review comment:
       So we have to fill a `null` to the constructor of SessionPool if we don't want to set timezone, right? 
   I think we'd better don't change these tests and add an extra test of setting timezone.

##########
File path: thrift/src/main/thrift/rpc.thrift
##########
@@ -79,9 +79,10 @@ struct TSOpenSessionResp {
 // Open a session (connection) on the server against which operations may be executed.
 struct TSOpenSessionReq {
   1: required TSProtocolVersion client_protocol = TSProtocolVersion.IOTDB_SERVICE_PROTOCOL_V3
-  2: optional string username
-  3: optional string password
-  4: optional map<string, string> configuration
+  2: required string zoneId
+  3: optional string username
+  4: optional string password
+  5: optional map<string, string> configuration

Review comment:
       Please update `thrift/rpc-changelist.md`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org